-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: cleanup extra cars #1905
base: master
Are you sure you want to change the base?
docs: cleanup extra cars #1905
Conversation
@jyoung8607 I don't have time for this now, but this is a good proof of concept. Want to take it over? Does this look reasonable to you? You just need to ignore != SupportType.UPSTREAM on the site jinja template |
ExtraPlatform = Platform | EXTRA | ||
EXTRA_BRANDS = get_args(ExtraPlatform) | ||
EXTRA_PLATFORMS: dict[str, ExtraPlatform] = {str(platform): platform for brand in EXTRA_BRANDS for platform in brand} | ||
|
||
|
||
def get_params_for_docs(platform) -> CarParams: | ||
cp_platform = platform if platform in interfaces else MOCK.MOCK |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we can remove this once done
It's more than the CARS.md jinja template, it's the functions consumed by comma.ai/vehicles and shop.comma.ai. At the time I wasn't free to alter that interface at all. Hence the EXTRA_STUFF, so those original functions could continue filtering down to the set of release-supported cars. Lines 65 to 69 in 01c1a42
Lines 84 to 93 in 01c1a42
|
No description provided.