safety: fwd hook config #1954
Open
safety: fwd hook config #1954
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sshane
commented
Mar 8, 2025
|
blockers:
|
sshane
commented
Mar 8, 2025
| @@ -49,8 +52,14 @@ typedef struct { | |||
| int addr; | |||
| int bus; | |||
| int len; | |||
| bool blocked; | |||
There was a problem hiding this comment.
Suggested change
| bool blocked; | |
| bool block_fwding; // or no_fwding |
makes this more clear
opendbc/safety/safety_declarations.h
Outdated
| @@ -151,6 +160,7 @@ typedef struct { | |||
| int rx_checks_len; | |||
| const CanMsg *tx_msgs; | |||
| int tx_msgs_len; | |||
| bool block_fwding; | |||
There was a problem hiding this comment.
I'd call this enable_forwarding or disable_forwarding
This was referenced Mar 9, 2025
sshane
added a commit
that referenced
this pull request
Mar 10, 2025
sshane
added a commit
that referenced
this pull request
Mar 11, 2025
* Do Toyota relay malfunction config * clean up * not needed * rm this * rm * fix * great name (rename after #1954) * do gm * need this since we will dynamically block it * subie * some more brands * Ford * Chrysler * Hyundai * huge oof hyundai * toyota & vw * fix * tesla * 0x194 isn't on Honda Bosch * Honda: we can check bus 1 for 0xe4 * misra * static * ugh need this * correct * nl * like * space
chrispypatt
pushed a commit
to chrispypatt/opendbc
that referenced
this pull request
Mar 12, 2025
* Do Toyota relay malfunction config * clean up * not needed * rm this * rm * fix * great name (rename after commaai#1954) * do gm * need this since we will dynamically block it * subie * some more brands * Ford * Chrysler * Hyundai * huge oof hyundai * toyota & vw * fix * tesla * 0x194 isn't on Honda Bosch * Honda: we can check bus 1 for 0xe4 * misra * static * ugh need this * correct * nl * like * space
sshane
force-pushed
the
fwd-config
branch
2 times, most recently
from
da484a8 to
0753240
Compare
This was referenced Mar 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1950
v2 of #1785
removes turing completeness
haven't checked all cases, but we might be able to just do the relay malfunction part of #1903 with nothing more than
blockedand a few more lines (plus checking a bunch more addresses automatically)!