Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Set GIT_REF as an environment variable for safety mutation tests #1956

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

devtekve
Copy link
Contributor

@devtekve devtekve commented Mar 8, 2025

This change moves the GIT_REF definition into the environment section, otherwise it's not really used as expected by the script

Note to maintainers

I can also set it like this

GIT_REF: ${{ github.event_name == 'push' && github.ref == format('refs/heads/{0}', github.event.repository.default_branch) && github.event.before || format('origin/{0}', github.event.repository.default_branch) }}

I think this is better for forks in the long run as some (like us at SP for the time being) use master-new for our rewrite with this it becomes more universal

This change moves the GIT_REF definition into the environment section, simplifying its use in the workflow steps. It ensures consistency and clarity by separating variable definition from execution commands.
@devtekve devtekve force-pushed the ci-fix-gitref-safety-mutation-tests branch from 61264cd to 2f3672c Compare March 8, 2025 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant