Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Acura 2022 RDX support #1967

Draft
wants to merge 10 commits into
base: master
Choose a base branch
from
Draft

Conversation

mvl-boston
Copy link

@mvl-boston mvl-boston commented Mar 10, 2025

PR for Acura RDX 2022

Replacement for PR1946
Resolution for bug 1647

Notes:

  • car fingerprint named 3G MMR. That is honda-speak for 3rd generation mid-model refresh. Segregated 2022 fingerprints from 2019-2021 fingerprints.
  • RDX uses imperial speed/cruise units on the canbus in the USA, Canadian RDXs probably use metric. Rewrote the cruise unit to read the metric canbus flag, rather than be based on hardcoded fingerprint names, to automate support of this.
  • RDX removes steering when under 70kph with radar on (eg: when longitudinal is off). Identified the canbus flag that identifies the steering lockout, and set a low speed warning when this occurs. Will also serve as a warning to steering lockout that occurs when a driver adds too much manual torque.

Current state:

  • per feedback on Honda/Acura discord, moving this back to draft for the following reasons:
  1. Need a route with full rlogs
  2. Need to isolate changes specific to the RDX to prevent risk of regression to other cars.
  • due to issues with longitudinal, and longitudinal still being an alpha product, I removed longitudinal tuning and will add support later when I can retest it. Did not want to hold up pr so that car can be added back to compatibility list.
  • regression on gas strength found that this model runs 1 m/s per 1000 gas units. Existing code has 1m/s per 800 units for Bosch. Unsure if this model is different (or other Bosch models are tuned wrong) so previously wrote logic that flips to 1000 units only for this fingerprint. Delayed this logic until longitudinal is working/tested, as non-longitudinal does not use this feature, to minimize complexity of PR.
  • have not heard back from community member with 2023 RDX model for fingerprint. Have a portable mount and will see if local dealership will let me fingerprint their car instead.

@mvl-boston mvl-boston marked this pull request as draft March 10, 2025 05:11
@github-actions github-actions bot added car related to opendbc/car/ honda labels Mar 10, 2025
@mvl-boston mvl-boston marked this pull request as ready for review March 10, 2025 05:36
@mvl-boston mvl-boston marked this pull request as draft March 12, 2025 06:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
car related to opendbc/car/ honda
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant