Skip to content

Conversation

@elkoled
Copy link
Contributor

@elkoled elkoled commented Jan 30, 2026

Enable import from openpilot by lazy loading comma_car_segments

@github-actions github-actions bot added the car related to opendbc/car/ label Jan 30, 2026
@elkoled
Copy link
Contributor Author

elkoled commented Jan 30, 2026

@sshane ready

@github-actions
Copy link
Contributor

No car changes detected

@sshane
Copy link
Contributor

sshane commented Jan 30, 2026

what's different with this change?

@elkoled
Copy link
Contributor Author

elkoled commented Jan 30, 2026

it is needed to fix comma_car_segments import error when using car_diff from openpilot.

@sshane
Copy link
Contributor

sshane commented Jan 31, 2026

What is the error? Is there a PR?

@elkoled
Copy link
Contributor Author

elkoled commented Jan 31, 2026

Here it is:
commaai/openpilot#37048

@elkoled elkoled changed the title Car diff: import from openpilot Car diff: lazy load Jan 31, 2026
@elkoled elkoled merged commit 50f1b43 into master Jan 31, 2026
14 checks passed
@elkoled elkoled deleted the car-diff-lazy branch January 31, 2026 03:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

car related to opendbc/car/

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants