Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate removing release file whitelist #34001

Open
adeebshihadeh opened this issue Nov 12, 2024 · 1 comment
Open

Investigate removing release file whitelist #34001

adeebshihadeh opened this issue Nov 12, 2024 · 1 comment
Assignees
@maxime-desroches
Labels
cleanup enhancement

Comments

@adeebshihadeh
Copy link
Contributor

If it doesn't inflate release size much, I think we should just remove the file whitelisting. It simplifies things, and we don't have to worry about running the tests in both modes.
@adeebshihadeh
Copy link
Contributor Author

Another thing to consider here is the readability of the diff for releases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maxime-desroches maxime-desroches

Labels
cleanup enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@adeebshihadeh @maxime-desroches