Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hyundai: PCM and non-PCM longitudinal are not resuming with button press #34203

Open
sunnyhaibin opened this issue Dec 11, 2024 · 2 comments
Open
Labels
bug car vehicle-specific

Comments

@sunnyhaibin
Copy link
Contributor

sunnyhaibin commented Dec 11, 2024

Describe the bug

PCM longitudinal (stock system)

Non-PCM longitudinal (openpilot)

  • Unable to use the RESUME/+ button to resume with the previous set speed
  • Route with issue: 2bbe12792a30f61f/00000597--9b3c91c5dd

Which car does this affect?

2022 Hyundai Elantra, 2023 Genesis G70, 2019 Ioniq Plug-in Hybrid, 2023 Hyundai Kona EV

Provide a route where the issue occurs

Stock longitudinal issue: 2bbe12792a30f61f/0000059a--ff54a3ac71
openpilot longitudinal issue: 2bbe12792a30f61f/0000059b--63039b3804

openpilot version

master

Additional info

No response

@sunnyhaibin sunnyhaibin added bug car vehicle-specific labels Dec 11, 2024
@sunnyhaibin sunnyhaibin changed the title Hyundai: PCM and non-PCM longitudinal are not resuming Hyundai: PCM and non-PCM longitudinal are not resuming with button press Dec 11, 2024
@sunnyhaibin
Copy link
Contributor Author

Bug with PCM longitudinal unable to resume with PAUSE/RESUME seems to only affect some models.

2024 Hyundai Sonata (not affected)

  • carState/cruiseState/enabled goes rising edge after the PAUSE/RESUME button is released

image

2023 Genesis G70 (affected)

  • carState/cruiseState/enabled goes rising edge before the PAUSE/RESUME button is released

image

@sunnyhaibin
Copy link
Contributor Author

Routes with bugs mentioned in this issue:

  • Stock longitudinal issue: 2bbe12792a30f61f/0000059a--ff54a3ac71
  • openpilot longitudinal issue: 2bbe12792a30f61f/0000059b--63039b3804

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug car vehicle-specific
Projects
None yet
Development

No branches or pull requests

1 participant