Skip to content

Conversation

TheSecurityDev
Copy link
Contributor

@TheSecurityDev TheSecurityDev commented Oct 13, 2025

Adds a screenshot test case for the experimental mode description.

Part of it might be cut off at the bottom because we need scroll support. I figured out a better way to scroll that doesn't require xdotool, (updated my other PR also), so I can do that here if you like, or in a followup PR.

Ahh, it looks like it just barely fit after all.

@Copilot Copilot AI review requested due to automatic review settings October 13, 2025 19:48
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Adds a new screenshot test case for the experimental mode description in the raylib UI tests. This allows capturing screenshots of the expanded experimental mode description panel for testing purposes.

  • Adds a new test setup function for the experimental mode description
  • Registers the new test case in the CASES dictionary

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@github-actions github-actions bot added the ui label Oct 13, 2025
Copy link
Contributor

github-actions bot commented Oct 13, 2025

raylib UI Preview

All Screenshots

@sshane
Copy link
Contributor

sshane commented Oct 13, 2025

Part of it might be cut off at the bottom because we need scroll support. I figured out a better way to scroll that doesn't require xdotool, (updated my other PR also), so I can do that here if you like, or in a followup PR.

so the most useful thing here isn't seeing the entire description, it's seeing that the html renderer is properly rendering the description at least somewhat. it's not entirely broken (which it was before)

@sshane sshane merged commit 692f5fd into commaai:master Oct 13, 2025
12 of 13 checks passed
@sshane
Copy link
Contributor

sshane commented Oct 13, 2025

Want to add the confirmation dialog too?

@maxime-desroches
Copy link
Collaborator

We should also have text entered on the keyboard screenshot

@TheSecurityDev
Copy link
Contributor Author

TheSecurityDev commented Oct 13, 2025

Want to add the confirmation dialog too?

Isn't that already implemented? But I noticed the onroad UI is missing. I was thinking of trying that but maybe it's something you would rather do. Oh and the alerts with status colors would be good.

I could do the uppercase keyboard version, and one with numbers too.

@sshane
Copy link
Contributor

sshane commented Oct 13, 2025

Oh I mean for experimental mode/alpha long with html renderer

@sshane
Copy link
Contributor

sshane commented Oct 13, 2025

The full size alert was recently broken since there was no test for it, it'd be great to test that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants