Skip to content

Comments

Add User Account dropin docs#104

Merged
keharper merged 18 commits intodevelopfrom
account-atwix
Nov 11, 2024
Merged

Add User Account dropin docs#104
keharper merged 18 commits intodevelopfrom
account-atwix

Conversation

@keharper
Copy link
Contributor

@keharper keharper commented Nov 7, 2024

This PR adds user account dropin docs.

@keharper keharper added the documentation Improvements or additions to documentation label Nov 7, 2024
@keharper keharper self-assigned this Nov 7, 2024
@keharper keharper marked this pull request as ready for review November 10, 2024 20:38
Copy link
Contributor

@jeff-matthews jeff-matthews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @keharper.

I only made superficial editorial suggestions. Specifically where the approved naming convention applies to "dropins".

Approved convention from internal wiki:

  • "Drop-in components" is preferred over "DropIns."
    the name structure [Functional Name] Drop-in is correct for individual drop-ins. Acronyms should not be used as part of the name. (from Branding)

  • "Cart drop-in component", once established, can be written as, "the cart component" or "the cart").

Copy link
Contributor

@KostiantynFandeliuk KostiantynFandeliuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thank you.

@keharper keharper merged commit af89c3b into develop Nov 11, 2024
@keharper keharper deleted the account-atwix branch November 11, 2024 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants