optimize okhttp4 client to not hold local references to response body

commercetools · Oct 10, 2024 · 14cbeb5 · 14cbeb5
1 parent c12b266
commit 14cbeb5
Showing 1 changed file with 4 additions and 5 deletions.
diff --git a/...rcetools-okhttp-client4/src/main/java/com/commercetools/http/okhttp4/CtOkHttp4Client.java b/...rcetools-okhttp-client4/src/main/java/com/commercetools/http/okhttp4/CtOkHttp4Client.java
@@ -201,17 +201,15 @@ public okhttp3.Response intercept(Chain chain) throws IOException {
             return unzip(response);
         }
 
-        private okhttp3.Response unzip(final okhttp3.Response response) throws IOException {
+        private okhttp3.Response unzip(final okhttp3.Response response) {
             if (!"gzip".equalsIgnoreCase(response.header("Content-Encoding"))) {
                 return response;
             }
 
-            okhttp3.ResponseBody responseBody = response.body();
-            if (responseBody == null) {
+            if (response.body() == null) {
                 return response;
             }
 
-            GzipSource gzipSource = new GzipSource(responseBody.source());
             okhttp3.Headers strippedHeaders = response.headers()
                     .newBuilder()
                     .removeAll("Content-Encoding")
@@ -220,7 +218,8 @@ private okhttp3.Response unzip(final okhttp3.Response response) throws IOExcepti
             String contentType = response.header("Content-Type");
             return response.newBuilder()
                     .headers(strippedHeaders)
-                    .body(okhttp3.ResponseBody.create(Okio.buffer(gzipSource), okhttp3.MediaType.get(contentType), -1L))
+                    .body(okhttp3.ResponseBody.create(Okio.buffer(new GzipSource(response.body().source())),
+                        okhttp3.MediaType.get(contentType), -1L))
                     .build();
         }
     }