Add authproxy connector HMAC support #2
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The default signature header Gap-Signature is used by Buzzfeed [1]. The upstream hmac library used to calculate the signature is very old (as of writing last update 2017) but it minimizes the work to do here as implementation is trying to match the signing process of Buzzfeed [2]. It seems that signature is not calculated in a standard way; client chooses what to include in the calculation of the signature and the server must use the same input to get a matching signature. [1] https://github.com/buzzfeed/sso/blob/549155a64d6c5f8916ed909cfa4e340734056284/internal/proxy/oauthproxy.go#L25 [2] https://github.com/buzzfeed/sso/blob/549155a64d6c5f8916ed909cfa4e340734056284/docs/sso_config.md?plain=1#L105
|
Closing as we're not going this direction right now. |
|
This PR is missing a Jira ticket reference in the title or description. |
|
🥷 Code experts: no user matched threshold 10 See details
Knowledge based on git-blame:
Knowledge based on git-blame:
Knowledge based on git-blame:
Knowledge based on git-blame: To learn more about /:\ gitStream - Visit our Docs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default signature header Gap-Signature is used by Buzzfeed [1].
The upstream hmac library used to calculate the signature is very old (as of writing last update 2017) but it minimizes the work to do here as implementation is trying to match the signing process of Buzzfeed [2].
It seems that signature is not calculated in a standard way; client chooses what to include in the calculation of the signature and the server must use the same input to get a matching signature.
[1] https://github.com/buzzfeed/sso/blob/549155a64d6c5f8916ed909cfa4e340734056284/internal/proxy/oauthproxy.go#L25
[2] https://github.com/buzzfeed/sso/blob/549155a64d6c5f8916ed909cfa4e340734056284/docs/sso_config.md?plain=1#L105
Overview
What this PR does / why we need it
Special notes for your reviewer