Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move data for test to testdata #82

Merged
merged 5 commits into from
Nov 14, 2021
Merged

Move data for test to testdata #82

merged 5 commits into from
Nov 14, 2021

Conversation

tom-tan
Copy link
Member

@tom-tan tom-tan commented Nov 12, 2021

The new directory structure is as follows: testdata/$cwlVersion/filename.cwl.
It makes easier to distinguish CWLVersion for each file and also makes easier to make tests that depend on directory structure as discussed in #78.

@codecov
Copy link

codecov bot commented Nov 12, 2021

Codecov Report

Merging #82 (e9db361) into main (c734ade) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #82   +/-   ##
=======================================
  Coverage   50.43%   50.43%           
=======================================
  Files           3        3           
  Lines         462      462           
=======================================
  Hits          233      233           
  Misses        229      229           
Impacted Files Coverage Δ
tests/test_complete.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c734ade...e9db361. Read the comment docs.

@mr-c mr-c enabled auto-merge (rebase) November 12, 2021 10:56
Copy link
Member

@mr-c mr-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Please update MANIFEST.in to notice these new directories so that the release test passes

auto-merge was automatically disabled November 12, 2021 11:02

Head branch was pushed to by a user without write access

@tom-tan
Copy link
Member Author

tom-tan commented Nov 12, 2021

Done!

@mr-c mr-c enabled auto-merge (squash) November 12, 2021 11:23
auto-merge was automatically disabled November 14, 2021 09:37

Head branch was pushed to by a user without write access

@mr-c mr-c merged commit f978ed9 into common-workflow-language:main Nov 14, 2021
@mr-c
Copy link
Member

mr-c commented Nov 14, 2021

Thank you @tom-tan !

@tom-tan tom-tan deleted the structured-test branch November 14, 2021 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants