Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validates file with SchemaDefRequirement #1475

Merged
merged 3 commits into from
Jul 22, 2021
Merged

Validates file with SchemaDefRequirement #1475

merged 3 commits into from
Jul 22, 2021

Conversation

tetron
Copy link
Member

@tetron tetron commented Jul 21, 2021

Fixes #1473

@codecov
Copy link

codecov bot commented Jul 21, 2021

Codecov Report

Merging #1475 (ccfccd7) into main (7094ede) will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1475      +/-   ##
==========================================
+ Coverage   65.73%   65.76%   +0.03%     
==========================================
  Files          89       89              
  Lines       15608    15608              
  Branches     3925     3925              
==========================================
+ Hits        10260    10265       +5     
+ Misses       4256     4253       -3     
+ Partials     1092     1090       -2     
Impacted Files Coverage Δ
cwltool/process.py 84.24% <100.00%> (ø)
cwltool/job.py 77.41% <0.00%> (-0.42%) ⬇️
cwltool/main.py 62.00% <0.00%> (+0.42%) ⬆️
cwltool/validate_js.py 84.03% <0.00%> (+3.36%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7094ede...ccfccd7. Read the comment docs.

@mr-c mr-c enabled auto-merge (squash) July 22, 2021 13:53
@mr-c mr-c merged commit 1fb45c8 into main Jul 22, 2021
@mr-c mr-c deleted the fix-schemadef branch July 22, 2021 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cwltool --validate fails on packed json when using schemas in version 3.1.20210628163208
2 participants