guard import fcntl for windows
#1914
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfennick
changed the title
import tcntl for windowsimport fcntl for windows
Codecov Report
@@ Coverage Diff @@
## main #1914 +/- ##
==========================================
- Coverage 83.95% 83.94% -0.01%
==========================================
Files 46 46
Lines 8162 8165 +3
Branches 2168 2168
==========================================
+ Hits 6852 6854 +2
+ Misses 841 840 -1
- Partials 469 471 +2
|
auto-merge was automatically disabled
September 27, 2023 15:35
Head branch was pushed to by a user without write access
jfennick
force-pushed
the
guard_import_fcntl
branch
from
feca5f7
to
0f89f01
Compare
|
FYI build_test_container is failing due to an (apparently) unrelated error with schema-salad: |
|
@jfennick Thanks for a heads up; I made a new schema-salad release since the issue was already fixed |
mr-c
approved these changes
Sep 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is essentially identical to #1822 It simply guards the
import fcntlon windows so that the proper error message can be displayed.