-
-
Notifications
You must be signed in to change notification settings - Fork 67
how to specify network access with example #381
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Fienne
wants to merge
6
commits into
common-workflow-language:main
Choose a base branch
from
Fienne:document-network-access
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+45
−0
Open
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
cefdd8a
how to specify network access with example
Fienne b0dd765
add semantic breaks and change curl capitalization
Fienne d3b6994
add more info on network access
Fienne 5a9eca3
remove duplication and adjust semantic breaks
Fienne 2f6dc78
more info on network access requirement
Fienne d79bab1
format text
Fienne File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we also need to document what happens when
networkAccess: false
. I believe this flag is a suggestion, and it may or may not block the network access (it does not incwltool
, yet, common-workflow-language/cwltool#1733).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The flag doesn't block the network access; I ran the above code with
networkAcess: false
and it still downloaded the file.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correct. It's planned work for
cwltool
. But would be useful to document the expected behavior in the spec and maybe in cwltool as well.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So can I say that when the
networkAccess
value isfalse
, the code still runs, but we do not expect it to?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we must say what happens in both cases. We can probably use or adapt the text from the specification, where it explains it's an indicative flag, what implementations/users can expect, and the meaning of
true
orfalse
for the flag: https://www.commonwl.org/v1.2/CommandLineTool.html#NetworkAccessThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright, thanks!