Skip to content

Conversation

@SavageCore
Copy link

@SavageCore SavageCore commented Dec 19, 2025

Scripts wich are clearly AI generated and not further revied by the Author of this PR (in terms of Coding Standards and Script Layout) may be closed without review.

✍️ Description

Installs https://github.com/vogler/free-games-claimer

For Debian 13 compatibility I manually upgrade https://github.com/Kaliiiiiiiiii-Vinyzu/patchright to 1.55+

🔗 Related PR / Issue

Link: #

✅ Prerequisites (X in brackets)

  • Self-review completed – Code follows project standards.
  • Tested thoroughly – Changes work as expected.
  • No breaking changes – Existing functionality remains intact.
  • No security risks – No hardcoded secrets, unnecessary privilege escalations, or permission issues.

🛠️ Type of Change (X in brackets)

  • 🐞 Bug fix – Resolves an issue without breaking functionality.
  • New feature – Adds new, non-breaking functionality.
  • 💥 Breaking change – Alters existing functionality in a way that may require updates.
  • 🆕 New script – A fully functional and tested script or script set.
  • 🌍 Website update – Changes to website-related JSON files or metadata.
  • 🔧 Refactoring / Code Cleanup – Improves readability or maintainability without changing functionality.
  • 📝 Documentation update – Changes to README, AppName.md, CONTRIBUTING.md, or other docs.

🔍 Code & Security Review (X in brackets)

  • Follows Code_Audit.md & CONTRIBUTING.md guidelines
  • Uses correct script structure (AppName.sh, AppName-install.sh, AppName.json)
  • No hardcoded credentials

📋 Additional Information (optional)

@SavageCore SavageCore requested review from a team as code owners December 19, 2025 16:20
@SavageCore SavageCore changed the title feat: free-games-claimer Add free-games-claimer Dec 19, 2025
@SavageCore SavageCore marked this pull request as draft December 19, 2025 20:36
@SavageCore SavageCore force-pushed the feature/free-games-claimer branch 4 times, most recently from 13a8aa1 to 9e4459a Compare December 19, 2025 20:59
@SavageCore SavageCore force-pushed the feature/free-games-claimer branch from 9e4459a to 9ed1684 Compare December 19, 2025 21:00
@SavageCore SavageCore marked this pull request as ready for review December 19, 2025 21:06
@SavageCore SavageCore force-pushed the feature/free-games-claimer branch from e5b84c9 to 0d268d2 Compare December 19, 2025 22:09
Comment on lines 61 to 70
# Display success message
msg_ok "Completed Successfully!\n"
echo -e "${CREATING}${GN}${APP} setup has been successfully completed!${CL}"
echo -e "${INFO}${YW}Next you need to configure your credentials by editing the config file located at:${CL}"
echo -e "${INFO}${YW}/opt/free-games-claimer/data/config.env${CL}"
echo -e "${INFO}${YW}After that you can start with the following command:${CL}\n"
echo -e "${TAB}${BOLD}systemctl start free-games-claimer${CL}"
echo -e "${INFO}${YW} When running you can access VNC to watch the browser using the following URL:${CL}"
echo -e "${TAB}${GATEWAY}${BGN}http://${IP}:6080${CL}"
echo -e "${INFO}${YW} There's a cron job set-up to run the claimer every day at 18:30.${CL}"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use our default ending like in all our other scripts.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, where should those configuration instructions go? On the docs side somewhere?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, you have the notes field in the .json where such things belong.

@SavageCore SavageCore force-pushed the feature/free-games-claimer branch from 6986b20 to dfd5562 Compare January 5, 2026 18:29
$STD npm install

PATCHRIGHT_VERSION=$(npm list patchright | grep patchright@ | awk -F@ '{print $2}' | tr -d ' ')
REQUIRED_VERSION="1.55.0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the hardcoded part needed? When the devs changes the Req. Minimum Version we need to do a PR to fix that, we want to avoid such things. Can you pull the version out of package.json? Or in other words, wouldn´t it get updated with npm install anyway?

Comment on lines +55 to +61
msg_info "Installing free-games-claimer"
fetch_and_deploy_gh_release "free-games-claimer" "vogler/free-games-claimer" "tarball"
msg_ok "Installed free-games-claimer"
msg_info "Installing NPM Packages"
$STD npm install
$STD npx patchright install chromium --no-shell
msg_ok "Installed NPM Packages"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
msg_info "Installing free-games-claimer"
fetch_and_deploy_gh_release "free-games-claimer" "vogler/free-games-claimer" "tarball"
msg_ok "Installed free-games-claimer"
msg_info "Installing NPM Packages"
$STD npm install
$STD npx patchright install chromium --no-shell
msg_ok "Installed NPM Packages"
fetch_and_deploy_gh_release "free-games-claimer" "vogler/free-games-claimer" "tarball"
msg_info "Installing free-games-claimer"
$STD npm install
$STD npx patchright install chromium --no-shell
msg_ok "Installed free-games-claimer"

NOTIFY=
EOF

msg_ok "Installed free-games-claimer"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
msg_ok "Installed free-games-claimer"


msg_ok "Installed free-games-claimer"

msg_info "Creating Services"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
msg_info "Creating Services"

install_packages_with_retry "novnc"
msg_ok "Installed noVNC"
$STD ln -s /usr/share/novnc/vnc_auto.html /usr/share/novnc/index.html

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
msg_info "Creating Service"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants