-
-
Notifications
You must be signed in to change notification settings - Fork 182
Add free-games-claimer #1223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add free-games-claimer #1223
Conversation
13a8aa1 to
9e4459a
Compare
9e4459a to
9ed1684
Compare
e5b84c9 to
0d268d2
Compare
ct/free-games-claimer.sh
Outdated
| # Display success message | ||
| msg_ok "Completed Successfully!\n" | ||
| echo -e "${CREATING}${GN}${APP} setup has been successfully completed!${CL}" | ||
| echo -e "${INFO}${YW}Next you need to configure your credentials by editing the config file located at:${CL}" | ||
| echo -e "${INFO}${YW}/opt/free-games-claimer/data/config.env${CL}" | ||
| echo -e "${INFO}${YW}After that you can start with the following command:${CL}\n" | ||
| echo -e "${TAB}${BOLD}systemctl start free-games-claimer${CL}" | ||
| echo -e "${INFO}${YW} When running you can access VNC to watch the browser using the following URL:${CL}" | ||
| echo -e "${TAB}${GATEWAY}${BGN}http://${IP}:6080${CL}" | ||
| echo -e "${INFO}${YW} There's a cron job set-up to run the claimer every day at 18:30.${CL}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use our default ending like in all our other scripts.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, where should those configuration instructions go? On the docs side somewhere?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, you have the notes field in the .json where such things belong.
6986b20 to
dfd5562
Compare
| $STD npm install | ||
|
|
||
| PATCHRIGHT_VERSION=$(npm list patchright | grep patchright@ | awk -F@ '{print $2}' | tr -d ' ') | ||
| REQUIRED_VERSION="1.55.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the hardcoded part needed? When the devs changes the Req. Minimum Version we need to do a PR to fix that, we want to avoid such things. Can you pull the version out of package.json? Or in other words, wouldn´t it get updated with npm install anyway?
| msg_info "Installing free-games-claimer" | ||
| fetch_and_deploy_gh_release "free-games-claimer" "vogler/free-games-claimer" "tarball" | ||
| msg_ok "Installed free-games-claimer" | ||
| msg_info "Installing NPM Packages" | ||
| $STD npm install | ||
| $STD npx patchright install chromium --no-shell | ||
| msg_ok "Installed NPM Packages" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| msg_info "Installing free-games-claimer" | |
| fetch_and_deploy_gh_release "free-games-claimer" "vogler/free-games-claimer" "tarball" | |
| msg_ok "Installed free-games-claimer" | |
| msg_info "Installing NPM Packages" | |
| $STD npm install | |
| $STD npx patchright install chromium --no-shell | |
| msg_ok "Installed NPM Packages" | |
| fetch_and_deploy_gh_release "free-games-claimer" "vogler/free-games-claimer" "tarball" | |
| msg_info "Installing free-games-claimer" | |
| $STD npm install | |
| $STD npx patchright install chromium --no-shell | |
| msg_ok "Installed free-games-claimer" | |
| NOTIFY= | ||
| EOF | ||
|
|
||
| msg_ok "Installed free-games-claimer" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| msg_ok "Installed free-games-claimer" |
|
|
||
| msg_ok "Installed free-games-claimer" | ||
|
|
||
| msg_info "Creating Services" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| msg_info "Creating Services" |
| install_packages_with_retry "novnc" | ||
| msg_ok "Installed noVNC" | ||
| $STD ln -s /usr/share/novnc/vnc_auto.html /usr/share/novnc/index.html | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| msg_info "Creating Service" |
Scripts wich are clearly AI generated and not further revied by the Author of this PR (in terms of Coding Standards and Script Layout) may be closed without review.
✍️ Description
Installs https://github.com/vogler/free-games-claimer
For Debian 13 compatibility I manually upgrade https://github.com/Kaliiiiiiiiii-Vinyzu/patchright to 1.55+
🔗 Related PR / Issue
Link: #
✅ Prerequisites (X in brackets)
🛠️ Type of Change (X in brackets)
README,AppName.md,CONTRIBUTING.md, or other docs.🔍 Code & Security Review (X in brackets)
Code_Audit.md&CONTRIBUTING.mdguidelinesAppName.sh,AppName-install.sh,AppName.json)📋 Additional Information (optional)