Sonobarr

[GoldenSpringness]

Scripts wich are clearly AI generated and not further revied by the Author of this PR (in terms of Coding Standards and Script Layout) may be closed without review.

✍️ Description

Adding Sonobarr

🔗 Related PR / Issue

Link: # Sonobarr Issue

✅ Prerequisites (X in brackets)

• Self-review completed – Code follows project standards.
• Tested thoroughly – Changes work as expected.
• No breaking changes – Existing functionality remains intact.
• No security risks – No hardcoded secrets, unnecessary privilege escalations, or permission issues.

---

🛠️ Type of Change (X in brackets)

• 🐞 Bug fix – Resolves an issue without breaking functionality.
• ✨ New feature – Adds new, non-breaking functionality.
• 💥 Breaking change – Alters existing functionality in a way that may require updates.
• 🆕 New script – A fully functional and tested script or script set.
• 🌍 Website update – Changes to website-related JSON files or metadata.
• 🔧 Refactoring / Code Cleanup – Improves readability or maintainability without changing functionality.
• 📝 Documentation update – Changes to README, AppName.md, CONTRIBUTING.md, or other docs.

---

🔍 Code & Security Review (X in brackets)

• Follows Code_Audit.md & CONTRIBUTING.md guidelines
• Uses correct script structure (AppName.sh, AppName-install.sh, AppName.json)
• No hardcoded credentials

📋 Additional Information (optional)

[michelroegl-brunner]

@GoldenSpringness any furhter progess on this? When will you be able for a review?

[GoldenSpringness]

@GoldenSpringness any furhter progess on this? When will you be able for a review?

had a minor setback, hopefully the next few days :)

[greptile-apps]

Greptile Summary

This PR adds Sonobarr installation scripts but contains several critical issues that must be resolved before merging.

Critical Issues:

• ct/sonobarr.sh:2 - Source URL points to feature branch instead of main, will break after merge
• ct/sonobarr.sh:27 - Update check uses -f (file) instead of -d (directory) test
• frontend/public/json/sonobarr.json:15 - Logo URL violates CDN requirement, uses external GitHub camo URL

Style/Best Practice Issues:

• install/sonobarr-install.sh:17 - Unsafe cd command without error handling
• install/sonobarr-install.sh:20-23 - Missing $STD wrappers on apt and pip commands
• install/sonobarr-install.sh:29 - Heredoc syntax doesn't follow project convention

The logic errors in the source URL and update check will cause runtime failures. The logo URL must use the selfh.st/icons CDN per project policy.

@michelroegl-brunner

Confidence Score: 1/5

• This PR has critical logic errors that will cause failures in production
• Score reflects multiple critical issues: the source URL points to a temporary feature branch that will break after merge, the update check will always fail due to wrong file test operator, and the logo URL violates project policy. Additionally, unsafe cd and missing output suppression wrappers indicate insufficient testing.
• All three files require attention: ct/sonobarr.sh has critical logic errors, frontend/public/json/sonobarr.json violates CDN policy, and install/sonobarr-install.sh has unsafe patterns and style violations

Important Files Changed

Filename	Overview
ct/sonobarr.sh	Critical issues: wrong source URL pointing to feature branch, incorrect check for directory vs file, missing $STD wrapper
install/sonobarr-install.sh	Multiple issues: missing $STD wrapper, using apt instead of apt-get, incorrect heredoc syntax, cd without error handling
frontend/public/json/sonobarr.json	Critical violation: logo URL doesn't use selfh.st/icons CDN format, uses external GitHub camo URL instead

[greptile-apps]

_{3 files reviewed, 7 comments}

_{Edit Code Review Agent Settings | Greptile}