Skip to content

Conversation

@bandogora
Copy link
Contributor

Scripts wich are clearly AI generated and not further revied by the Author of this PR (in terms of Coding Standards and Script Layout) may be closed without review.

✍️ Description

The clean_lxc() discription says it cleans Python, but it doesn't! Now it will.

# - Cleans: Python (pip/uv), Node.js (npm/yarn/pnpm), Go, Rust, Ruby, PHP

🔗 Related PR / Issue

Link:

✅ Prerequisites (X in brackets)

  • Self-review completed – Code follows project standards.
  • Tested thoroughly – Changes work as expected.
  • No breaking changes – Existing functionality remains intact.
  • No security risks – No hardcoded secrets, unnecessary privilege escalations, or permission issues.

🛠️ Type of Change (X in brackets)

  • 🐞 Bug fix – Resolves an issue without breaking functionality.
  • New feature – Adds new, non-breaking functionality.
  • 💥 Breaking change – Alters existing functionality in a way that may require updates.
  • 🆕 New script – A fully functional and tested script or script set.
  • 🌍 Website update – Changes to website-related JSON files or metadata.
  • 🔧 Refactoring / Code Cleanup – Improves readability or maintainability without changing functionality.
  • 📝 Documentation update – Changes to README, AppName.md, CONTRIBUTING.md, or other docs.

🔍 Code & Security Review (X in brackets)

  • Follows Code_Audit.md & CONTRIBUTING.md guidelines
  • Uses correct script structure (AppName.sh, AppName-install.sh, AppName.json)
  • No hardcoded credentials

📋 Additional Information (optional)


📦 Application Requirements (for new scripts)

Required for 🆕 New script submissions.
PRs that do not meet these requirements may be closed without review.

  • The application is at least 6 months old
  • The application is actively maintained
  • The application has 600+ GitHub stars
  • Official release tarballs are published

@greptile-apps
Copy link
Contributor

greptile-apps bot commented Jan 18, 2026

Greptile Summary

Adds Python cache cleanup commands (uv cache clean and pip cache purge) to the cleanup_lxc() function. The function description already stated it cleans Python caches, but the implementation was missing these commands.

Changes:

  • Added uv cache clean check and execution for Python uv package manager
  • Added pip cache purge check and execution for Python pip package manager
  • Commands follow the same pattern as existing package manager cleanups (conditional check, error suppression)
  • Placed logically before Node.js cleanup commands in the function

Confidence Score: 5/5

  • This PR is safe to merge with no risks
  • The change is a straightforward bug fix that adds missing Python cache cleanup functionality. It follows the exact same pattern as existing package manager cleanups in the function (conditional check with command availability, error suppression with || true). The implementation is non-breaking, consistent with the codebase style, and addresses a genuine discrepancy between the function's documentation and its actual behavior.
  • No files require special attention

Important Files Changed

Filename Overview
misc/core.func Adds missing Python cache cleanup (uv and pip) to cleanup_lxc() function

@MickLesk
Copy link
Member

I thought we removed this because it get Issues with cached packages.

@bandogora
Copy link
Contributor Author

@MickLesk I see this commit 987e7ee, but I don't see a linked PR or issue. Do you know what issue it caused?

@MickLesk
Copy link
Member

Maybe discord

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants