Skip to content

Add AllStarLink Script #164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

DonLocke
Copy link

@DonLocke DonLocke commented Apr 1, 2025

🛑 New scripts must first be submitted to ProxmoxVED for testing.
PRs for new scripts that skip this process will be closed.


✍️ Description

Added a new script to install AllStarLink with optional Allmon3.

✅ Prerequisites (X in brackets)

  • Self-review completed – Code follows project standards.
  • Tested thoroughly – Changes work as expected.
  • No breaking changes – Existing functionality remains intact.
  • No security risks – No hardcoded secrets, unnecessary privilege escalations, or permission issues.

🛠️ Type of Change (X in brackets)

  • 🐞 Bug fix – Resolves an issue without breaking functionality.
  • New feature – Adds new, non-breaking functionality.
  • 💥 Breaking change – Alters existing functionality in a way that may require updates.
  • 🆕 New script – A fully functional and tested script or script set.
  • 🌍 Website update – Changes to website-related JSON files or metadata.
  • 🔧 Refactoring / Code Cleanup – Improves readability or maintainability without changing functionality.
  • 📝 Documentation update – Changes to README, AppName.md, CONTRIBUTING.md, or other docs.

🔍 Code & Security Review (X in brackets)

  • Follows Code_Audit.md & CONTRIBUTING.md guidelines
  • Uses correct script structure (AppName.sh, AppName-install.sh, AppName.json)
  • No hardcoded credentials

📋 Additional Information (optional)

Copy link
Member

@michelroegl-brunner michelroegl-brunner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the header file.

@DonLocke
Copy link
Author

DonLocke commented Apr 2, 2025

Please remove the header file.

Why remove the header file?

@CrazyWolf13
Copy link
Member

@DonLocke Because our Github-Action autogenerates it.

Co-authored-by: Slaviša Arežina <[email protected]>
Copy link
Contributor

github-actions bot commented Apr 2, 2025

⚠️ The script ct/allstarlink.sh failed with the following message:

curl: (22) The requested URL returned error: 404
TERM environment variable needs set.
TERM environment variable not set.

@DonLocke
Copy link
Author

DonLocke commented Apr 2, 2025

⚠️ The script ct/allstarlink.sh failed with the following message:
curl: (22) The requested URL returned error: 404 TERM environment variable needs set. TERM environment variable not set.

I don't understand what this means, can someone help me out and explain what this needs?

Edit: It looks like @MickLesk changed the url and it broke the action? Is the build script broken in this repo?

@MickLesk
Copy link
Member

MickLesk commented Apr 3, 2025

the action is currently broken, @michelroegl-brunner look at this the next days

Co-authored-by: Slaviša Arežina <[email protected]>
@DonLocke
Copy link
Author

DonLocke commented Apr 4, 2025

Okay I have actually found a bug with the install, maybe a more advanced linux user can give me some guidance. This application depends on a kernal driver called dahdi, which seems to install fine but can't seem to be loaded by the application. Running modprobe dahdi is has a FATAL not found, and its looking in 6.8.12-9.pve but shouldn't it be looking in 6.1.0-32-amd64?

@vhsdream vhsdream force-pushed the main branch 2 times, most recently from 46b86e4 to 341a285 Compare April 4, 2025 17:23
@MickLesk
Copy link
Member

MickLesk commented Apr 4, 2025

Proxmox LXCs use the kernel of the Main PVE, This is actually also the purpose of LXCs, i.e. like a shared kernel.

@DonLocke
Copy link
Author

DonLocke commented Apr 4, 2025

Proxmox LXCs use the kernel of the Main PVE, This is actually also the purpose of LXCs, i.e. like a shared kernel.

So then there isn't a way to do this? It has to be either privileged (So it can install the driver) or a VM? Or is there some workaround?

@MickLesk
Copy link
Member

MickLesk commented Apr 4, 2025

VM should be the better way

@DonLocke
Copy link
Author

DonLocke commented Apr 4, 2025

VM should be the better way

I'll try and refactor this script over the weekend then, thank you for the advice!

@DonLocke
Copy link
Author

Can I get some eyes on this again? I think it should be all set, seems like the actions pass too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants