Skip to content

JumpServer #198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
May 5, 2025
Merged

JumpServer #198

merged 12 commits into from
May 5, 2025

Conversation

opastorello
Copy link
Contributor

✍️ Description

JumpServer is an open-source Privileged Access Management (PAM) tool that provides DevOps and IT teams with on-demand and secure access to SSH, RDP, Kubernetes, Database and RemoteApp endpoints through a web browser.

🔗 Related PR / Issue

Link: #191

✅ Prerequisites (X in brackets)

  • Self-review completed – Code follows project standards.
  • Tested thoroughly – Changes work as expected.
  • No breaking changes – Existing functionality remains intact.
  • No security risks – No hardcoded secrets, unnecessary privilege escalations, or permission issues.

🛠️ Type of Change (X in brackets)

  • 🐞 Bug fix – Resolves an issue without breaking functionality.
  • New feature – Adds new, non-breaking functionality.
  • 💥 Breaking change – Alters existing functionality in a way that may require updates.
  • 🆕 New script – A fully functional and tested script or script set.
  • 🌍 Website update – Changes to website-related JSON files or metadata.
  • 🔧 Refactoring / Code Cleanup – Improves readability or maintainability without changing functionality.
  • 📝 Documentation update – Changes to README, AppName.md, CONTRIBUTING.md, or other docs.

🔍 Code & Security Review (X in brackets)

  • Follows Code_Audit.md & CONTRIBUTING.md guidelines
  • Uses correct script structure (AppName.sh, AppName-install.sh, AppName.json)
  • No hardcoded credentials

Copy link
Contributor

⚠️ The script ct/jumpserver.sh failed with the following message:

curl: (22) The requested URL returned error: 404
Failed to open terminal.

MickLesk and others added 6 commits April 12, 2025 19:32
Co-authored-by: Slaviša Arežina <[email protected]>
Co-authored-by: Slaviša Arežina <[email protected]>
Co-authored-by: Slaviša Arežina <[email protected]>
Co-authored-by: Slaviša Arežina <[email protected]>
Co-authored-by: Slaviša Arežina <[email protected]>
@opastorello opastorello mentioned this pull request Apr 14, 2025
ct/jumpserver.sh Outdated
if [[ ! -f /opt/${APP}_version.txt ]] || [[ "${RELEASE}" != "$(cat /opt/${APP}_version.txt)" ]]; then
msg_info "Updating ${APP} to ${RELEASE}"
if [[ -d /opt/jumpserver/config ]]; then
msg_info "Backing up /opt/jumpserver/config"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not needed

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the "config" is not backed up, it is not possible to update.

Copy link
Member

@tremor021 tremor021 Apr 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mate, i'm telling you that msg_info is not needed, not that you shouldnt back up anything

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't understand lol

ct/jumpserver.sh Outdated
mkdir -p /opt/jumpserver
$STD tar -xzvf jumpserver-installer-${RELEASE}.tar.gz -C /opt/jumpserver --strip-components=1
if [[ -d /opt/jumpserver_config_backup ]]; then
msg_info "Restoring config backup"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not needed

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the "config" folder does not exist, it is not possible to update.

Copy link
Contributor Author

@opastorello opastorello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requested change made

n
n
EOF
$STD ./jmsctl.sh start
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why an start? Not an Service?

After reboot it never starts again?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are multiple Docker containers started with this command.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where dose this script even come from? The github? Cant you just use the steps native instead of calling a foreign script?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it would be feasible to do that.

@community-scripts community-scripts deleted a comment from github-actions bot Apr 23, 2025
@MickLesk
Copy link
Member

MickLesk commented May 5, 2025

i merge it for next steps

@MickLesk MickLesk merged commit 7d10077 into community-scripts:main May 5, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants