-
-
Notifications
You must be signed in to change notification settings - Fork 30
JumpServer #198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JumpServer #198
Conversation
curl: (22) The requested URL returned error: 404
Failed to open terminal. |
Co-authored-by: Slaviša Arežina <[email protected]>
Co-authored-by: Slaviša Arežina <[email protected]>
Co-authored-by: Slaviša Arežina <[email protected]>
Co-authored-by: Slaviša Arežina <[email protected]>
Co-authored-by: Slaviša Arežina <[email protected]>
Co-authored-by: Slaviša Arežina <[email protected]>
ct/jumpserver.sh
Outdated
if [[ ! -f /opt/${APP}_version.txt ]] || [[ "${RELEASE}" != "$(cat /opt/${APP}_version.txt)" ]]; then | ||
msg_info "Updating ${APP} to ${RELEASE}" | ||
if [[ -d /opt/jumpserver/config ]]; then | ||
msg_info "Backing up /opt/jumpserver/config" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not needed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the "config" is not backed up, it is not possible to update.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mate, i'm telling you that msg_info is not needed, not that you shouldnt back up anything
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't understand lol
ct/jumpserver.sh
Outdated
mkdir -p /opt/jumpserver | ||
$STD tar -xzvf jumpserver-installer-${RELEASE}.tar.gz -C /opt/jumpserver --strip-components=1 | ||
if [[ -d /opt/jumpserver_config_backup ]]; then | ||
msg_info "Restoring config backup" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not needed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the "config" folder does not exist, it is not possible to update.
Co-authored-by: Slaviša Arežina <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Requested change made
n | ||
n | ||
EOF | ||
$STD ./jmsctl.sh start |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why an start? Not an Service?
After reboot it never starts again?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are multiple Docker containers started with this command.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where dose this script even come from? The github? Cant you just use the steps native instead of calling a foreign script?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think it would be feasible to do that.
i merge it for next steps |
✍️ Description
JumpServer is an open-source Privileged Access Management (PAM) tool that provides DevOps and IT teams with on-demand and secure access to SSH, RDP, Kubernetes, Database and RemoteApp endpoints through a web browser.
🔗 Related PR / Issue
Link: #191
✅ Prerequisites (X in brackets)
🛠️ Type of Change (X in brackets)
README
,AppName.md
,CONTRIBUTING.md
, or other docs.🔍 Code & Security Review (X in brackets)
Code_Audit.md
&CONTRIBUTING.md
guidelinesAppName.sh
,AppName-install.sh
,AppName.json
)