Add pinchflat installation script for testing #693
Conversation
|
Hi there, I noticed that the auto-labeling action for my pull request has failed due to permission issues. The error message indicates that it does not have the necessary permissions to create labels on this repository. Here's the relevant part of the error message: "You do not have permission to create labels on this repository." Could you please check the permissions for the auto-labeler action? I want to ensure that my script can be reviewed and potentially merged. Also, I need to change the port from 8081 to 8945 within the script, at the bottom. I used the former for testing to minimise conflicts however, Keiran utilises the later in his script. Thank you for your help! |
There was a problem hiding this comment.
I think there is a more general problem
We have 3 different files:
- Frontend (json)
- Update script (ct/pinchflat.sh)
- install script (install/pinchflat-install.sh)
You seemd to have only the update script but made it in install dir without -install subfix, please correct this and add the other files:
here our guide: https://github.com/community-scripts/ProxmoxVE/wiki/CONTRIBUTING
|
Thank you for the review! I've made the following changes based on your feedback:
✅ Moved pinchflat.sh into ct/ Please let me know if there are any further changes needed! |
| @@ -0,0 +1,115 @@ | |||
| #!/usr/bin/env bash | |||
| source <(curl -fsSL https://raw.githubusercontent.com/community-scripts/ProxmoxVED/main/misc/build.func) | |||
| # Copyright (c) 2021-2025 ProxmoxVED | |||
There was a problem hiding this comment.
change this according to our other scripts.
| msg_ok "Backup created" | ||
|
|
||
| msg_info "Fetching and deploying latest ${APP} release" | ||
| fetch_and_deploy https://github.com/kieraneglin/pinchflat |
There was a problem hiding this comment.
that's not how this function works, please read through (or tell your AI Model, which you used) the description of the function I the first time.
| [Install] | ||
| WantedBy=multi-user.target | ||
| EOF | ||
| msg_ok "Patched systemd Service" |
| $STD systemctl daemon-reload | ||
| msg_ok "Service Updated" |
| @@ -0,0 +1,14 @@ | |||
| { | |||
There was a problem hiding this comment.
Where did you get this structure from?!
Please refrain from generating random stuff with AI and submitting it here.
Read the actual guide I linked https://github.com/community-scripts/ProxmoxVE/wiki/CONTRIBUTING and use this JSON generator:
https://community-scripts.github.io/ProxmoxVE/json-editor
| apt install -y git curl python3 python3-pip | ||
|
|
||
| # Clone and install Pinchflat | ||
| git clone https://github.com/kieraneglin/pinchflat /opt/pinchflat |
There was a problem hiding this comment.
As said we still don't do installs via git?
Didn't you understand this above?
Where is the virtual env install?
Look at the guide, this is nowwhere near what our install-scripts are like.
https://github.com/community-scripts/ProxmoxVE/wiki/CONTRIBUTING
|
I really suggest you start atually reading what I linked and not just generate random code you don't have a clue with AI and submit it here. Everyone with a tiny idea of bash knows that this does not work like this. |
|
Also remove that .DsStore file. |
|
Oh wow, I am failing miserably and I thought co-pilot would help me fill in my gaps whilst I juggle kids and life etc. I appreciate the blunt and matter of fact feedback. Clearly, not my strong area. All I was hoping to achieve was to get "https://github.com/kieraneglin/pinchflat" self-contained docker across onto your VE Helper-Scripts as an lxc. Originally, I looked other scripts that worked on my setup, tested it locally and was hoping that from the local instance to the global, it wouldn't be challenging. Boy, was I wrong. I do love a challenge and, I do love to share my experiences. I truly appreciate your time and will work on this again in my local environment and see where I land. Before I delve, this is "some" of my weaknesses? Read the actual guide I linked https://github.com/community-scripts/ProxmoxVE/wiki/CONTRIBUTING and use this JSON generator: Area | Action ct/pinchflat.sh | Remove fetch_and_deploy and systemctl, fix source line |
|
Hi @AkuchiS Yeah feel free to take your time on this I get the feeling :) And yes as pointed our we are meticulous when it comes to PR, but only like this we can hold up our standarts and deliver these well structured and safe to use scripts. A little note on AI: btw. Claude and ChatGPT are much better in this than copilot. |
|
@AkuchiS Also, making a script for this app is basically just translating Its not hard per se, it just requires a bit of testing and compliance with our contributor docs, as we require all scripts to follow specific rules |
|
Totally appreciated..will keep going down the rabbit hole when I've the time :) |
This pull request adds the pinchflat.sh installation script to the ProxmoxVE repository.
Overview:
The pinchflat.sh script automates the installation and setup process for the pinchflat application, which is a YouTube downloader. This script simplifies the installation by handling dependencies, setting up a Python virtual environment, and configuring a systemd service for easy management.
Key Features:
Installs necessary dependencies for the pinchflat application.
Sets up a Python virtual environment using pipenv.
Configures a systemd service to manage the application as a background service.
Backs up any existing installations before performing the update.
Source:
This script is based on the original work found in the kieraneglin/pinchflat repository.
Usage:
Once the script is executed, users can access the pinchflat application via the URL specified in the output, typically at http://:8945.