Remove commercial modules & add verbose install #760
Conversation
install/freepbx-install.sh
Outdated
| print_msg() { | ||
| local type="$1" | ||
| local txt_normal="${2:-}" | ||
| local txt_verbose="${3:-}" | ||
|
|
||
| local func="msg_$type" | ||
|
|
||
| if [[ "$VERBOSE" == "yes" ]]; then | ||
| if [[ -n "$txt_verbose" ]]; then | ||
| $func "$txt_verbose" | ||
| else | ||
| $func "$txt_normal\n" | ||
| fi | ||
| else | ||
| $func "$txt_normal" | ||
| fi | ||
| } |
There was a problem hiding this comment.
no need to use your own message func, we already have that
There was a problem hiding this comment.
Line 377 in 2e312c4
Shouldn't this cause a line break when in verbose mode?
To avoid this, for example:
⏳ Installing FreePBX (Patience)2025-07-27 21:22:58 - Performing version check...After adding the text, the text generated by the execution of the following command is added.
There was a problem hiding this comment.
maybe because you used msg_info and msg_ok no correctly?
every msg_info needs a msg_ok it's like if fi, a block that needs to be closed.
There was a problem hiding this comment.
As I understand it, when verbose is disabled, you first run msg_info to provide information about what's happening. Once the command is finished, you use msg_ok or msg_err, depending on how the process ends.
With verbose mode enabled, this isn't possible because you're displaying all the text on the console. Therefore, if you run msg_info and then another command, if it returns text to the console, it will be added to the same line, like the example I posted.
- Added option to remove commercial modules - Added option to update system and modules
✍️ Description
🔗 Related PR / Issue
Link: community-scripts/ProxmoxVE#6181
✅ Prerequisites (X in brackets)
🛠️ Type of Change (X in brackets)
README,AppName.md,CONTRIBUTING.md, or other docs.🔍 Code & Security Review (X in brackets)
Code_Audit.md&CONTRIBUTING.mdguidelinesAppName.sh,AppName-install.sh,AppName.json)📋 Additional Information (optional)