Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix CI dependency on compas #389

Merged
merged 1 commit into from
Oct 4, 2023
Merged

fix CI dependency on compas #389

merged 1 commit into from
Oct 4, 2023

Conversation

gonzalocasas
Copy link
Member

@gonzalocasas gonzalocasas commented Oct 4, 2023

Fixes #388

The CI workflow for IronPython depends on Debian's mirror of PyPi to install wheels, such as compas, because pip generally fails miserably, but now that compas 2.0alpha is released, the debian mirror incorrectly takes that version as /latest and there's no /stable redirect, so, we need to pin to the latest LTS version.

Once compas_fab moves to 2.x, we could unpin this again.

What type of change is this?

  • Bug fix in a backwards-compatible manner.
  • New feature in a backwards-compatible manner.
  • Breaking change: bug fix or new feature that involve incompatible API changes.
  • Other (e.g. doc update, configuration, etc)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I added a line to the CHANGELOG.md file in the Unreleased section under the most fitting heading (e.g. Added, Changed, Removed).
  • I ran all tests on my computer and it's all green (i.e. invoke test).
  • I ran lint on my computer and there are no errors (i.e. invoke lint).
  • I added new functions/classes and made them available on a second-level import, e.g. compas_fab.robots.CollisionMesh.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added necessary documentation (if appropriate)

@gonzalocasas gonzalocasas added the no changelog Disables changelog checker label Oct 4, 2023
Copy link
Contributor

@yck011522 yck011522 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I guess we cannot do semantic versioning here?

@gonzalocasas
Copy link
Member Author

I guess we cannot do semantic versioning here?

Unfortunately this service (the debian mirror doesn't seem to support it. I tried different variations but nothing worked.

@gonzalocasas gonzalocasas merged commit 9fa6d89 into main Oct 4, 2023
9 checks passed
@gonzalocasas gonzalocasas deleted the pin-compas-version branch October 4, 2023 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no changelog Disables changelog checker
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Compas 2.0.0 incorrectly used for
2 participants