Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Addition error in Duration() #417

Merged
merged 1 commit into from
Apr 19, 2024
Merged

Conversation

yck011522
Copy link
Contributor

Changed the behavior of Duration class when accepting both seconds (float) and nanoseconds (int) where the decimal point of seconds and the nanoseconds add up to more than 1 second.

In the following test (existing), the total duration is expected to be 3.1 seconds.

def test_sec_remainder_add_to_nsec():
    d = Duration(2.6, 5e8)
    assert d.seconds == 3.1

However, existing implementation did not carry on the values from nsec to sec when the total value adds up. The following test explains the more desirable behavior:

def test_sec_remainder_add_to_nsec():
    d = Duration(2.6, 5e8)
    assert d.secs == 3
    assert d.nsecs == 1e8
    assert d.seconds == 3.1

What type of change is this?

  • Bug fix in a backwards-compatible manner.
  • New feature in a backwards-compatible manner.
  • Breaking change: bug fix or new feature that involve incompatible API changes.
  • Other (e.g. doc update, configuration, etc)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I added a line to the CHANGELOG.md file in the Unreleased section under the most fitting heading (e.g. Added, Changed, Removed).
  • I ran all tests on my computer and it's all green (i.e. invoke test).
  • I ran lint on my computer and there are no errors (i.e. invoke lint).
  • I added new functions/classes and made them available on a second-level import, e.g. compas_fab.robots.CollisionMesh.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added necessary documentation (if appropriate)

Copy link
Member

@gonzalocasas gonzalocasas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@yck011522 yck011522 merged commit c62c368 into main Apr 19, 2024
14 checks passed
@yck011522 yck011522 deleted the yck011522/fix_time_addition_error branch April 19, 2024 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants