Skip to content

CHANGE authors references via AUTHORS.md file. #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

CHANGE authors references via AUTHORS.md file. #22

wants to merge 5 commits into from

Conversation

petrasvestartas
Copy link
Collaborator

AUTHORS.md file usage.

tomvanmele
tomvanmele reviewed Apr 6, 2025
View reviewed changes
src/compas_libigl/__init__.py Outdated
Comment on lines 15 to 18
__author__ = "See AUTHORS.md for more information about COMPAS libigl authors."
__copyright__ = "Block Research Group - ETH Zurich"
__license__ = "Mozilla Public License Version 2.0"
__email__ = "[email protected], petrasvestartas@gmail.com"
__email__ = "tom.v.mele@gmail.com"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in the interest of not duplicating information, perhaps we should just remove all of this, and just rely on the pyproject.toml file for all project meta data?

@tomvanmele
Copy link
Member

i know i suggested this change, but now seeing it, i am wondering if adding an Authors.md is a good idea. in fact i was thinking that we should even remove all meta data from the __init__.py file as well, and just use pyproject.toml for all meta data. then at least there is a single source for all this information...

@tomvanmele
Copy link
Member

except for __version__

@petrasvestartas
Copy link
Collaborator Author

i know i suggested this change, but now seeing it, i am wondering if adding an Authors.md is a good idea. in fact i was thinking that we should even remove all meta data from the __init__.py file as well, and just use pyproject.toml for all meta data. then at least there is a single source for all this information...

Yes it was a bit scattered in various places.
I placed now everything to pyproject.toml but I have no good understanding what is the good and appropriate way to do this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomvanmele tomvanmele tomvanmele left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@petrasvestartas @tomvanmele