Add ROM data parameter support via URL hash #2
+319
−63
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds support for passing ROM data directly via URL hash parameters, enabling users to share Game Boy games without hosting the ROM files.
Changes
demo/iframe/stores.js
to parse hash parameters alongside query parametersdemo/iframe/components/WasmBoy.svelte
to decode base64 ROM datarom-data
,rom-url
, androm-name
in URL hash fragmentImplementation Details
#
) instead of query parameters (?
) to keep ROM data privaterom-url
androm-name
if not found in hashURL Format
Motivation
This feature enables Compiler Explorer to embed Game Boy games directly in URLs without requiring external hosting, similar to how viciious handles C64 programs. This is particularly useful for:
Test Plan
npm run iframe:build
npm run iframe:dev
Example Usage
Limitations
Related
This implementation follows the same pattern as viciious for Compiler Explorer: compiler-explorer/viciious@aa132cd