-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pointerset + friends with pointers-to-pointers #471
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
🚀 New features to boost your workflow:
|
Performance Ratio:
|
@willtebbutt, can you address this issue to unblock DynamicPPL work? |
Ah, sorry, I forgot / didn't realise that this was blocking. The issues here are mainly to do with our testing infrastructure's handling of pointers being a little tricky to work with. I need to sort that out before this can be safely merged -- I think I've figured out what needs doing while working on the forwards-mode PR, so I'll take a look this afternoon. |
Will address #470 .
Todo:
pointerset
andatomic_pointerset
pointerset
andatomic_pointerset
(to enable testing of numerical correctness)edit: it looks like
pointerref
doesn't suffer from this problem, which is a relief.