-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
_copy_temp() to replace Base.copy() usage. #529
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
🚀 New features to boost your workflow:
|
@willtebbutt I'll start small with this function as |
@willtebbutt I think the test failures are unrelated, they even spring up on PR #531 . All my tests pass locally. Also turns out Base.deepcopy was failing at an edge case so ive opened up an Issue and PR JuliaLang/julia#57882 for that as well, Base.deepcopy and my function should both work. |
Once #531 is merged, you should just need to merge the changes from that PR into this one, and CI should start passing again. |
If you sync this branch with main, it should clear up any errors caused by the issue with AllocCheck. |
Although all tests pass here (as expected) I'm still working on the edge case PR for |
Second PR - Avoid type piracy and define a custom function to copy outputs of supported types. Refer #517 .