Skip to content

GHA: allow overriding the repo manifest #908

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 28, 2025
Merged

Conversation

compnerd
Copy link
Owner

Enable building with a custom fork of the repo manifest enabling patched forks to be used as the source of a build.

@compnerd compnerd requested a review from hjyamauchi February 27, 2025 01:14
Copy link
Collaborator

@hjyamauchi hjyamauchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

hjyamauchi added a commit that referenced this pull request Feb 27, 2025
hjyamauchi added a commit to thebrowsercompany/swift-build that referenced this pull request Feb 27, 2025
hjyamauchi added a commit to thebrowsercompany/swift-build that referenced this pull request Feb 27, 2025
hjyamauchi added a commit to thebrowsercompany/swift-build that referenced this pull request Feb 27, 2025
hjyamauchi added a commit to thebrowsercompany/swift-build that referenced this pull request Feb 27, 2025
hjyamauchi added a commit to thebrowsercompany/swift-build that referenced this pull request Feb 27, 2025
hjyamauchi added a commit to thebrowsercompany/swift-build that referenced this pull request Feb 27, 2025
hjyamauchi added a commit to thebrowsercompany/swift-build that referenced this pull request Feb 27, 2025
hjyamauchi added a commit to thebrowsercompany/swift-build that referenced this pull request Feb 27, 2025
hjyamauchi added a commit to thebrowsercompany/swift-build that referenced this pull request Feb 27, 2025
hjyamauchi added a commit to thebrowsercompany/swift-build that referenced this pull request Feb 27, 2025
hjyamauchi added a commit to thebrowsercompany/swift-build that referenced this pull request Feb 27, 2025
hjyamauchi added a commit to thebrowsercompany/swift-build that referenced this pull request Feb 27, 2025
hjyamauchi added a commit to thebrowsercompany/swift-build that referenced this pull request Feb 27, 2025
@compnerd compnerd force-pushed the compnerd/customisation branch from eca1cbd to ba13422 Compare February 27, 2025 21:44
Enable building with a custom fork of the repo manifest enabling patched
forks to be used as the source of a build.
@compnerd compnerd force-pushed the compnerd/customisation branch from ba13422 to 552d12b Compare February 27, 2025 21:46
@compnerd compnerd merged commit ac89057 into main Feb 28, 2025
47 of 48 checks passed
@compnerd compnerd deleted the compnerd/customisation branch February 28, 2025 18:07
@hjyamauchi
Copy link
Collaborator

Sorry for a late comment. I think we'd want to parameterize the branch_name as well so we can point to not only a person's branch but also a branch in it

@compnerd
Copy link
Owner Author

Sorry for a late comment. I think we'd want to parameterize the branch_name as well so we can point to not only a person's branch but also a branch in it

That is not possible - we no longer have any free inputs left. The workflow dispatch is limited to 10 inputs.

@hjyamauchi
Copy link
Collaborator

ok does that mean that the branch name of a person's repo must be either main or a release version number like 6.0.1, I think

@compnerd
Copy link
Owner Author

ok does that mean that the branch name of a person's repo must be either main or a release version number like 6.0.1, I think

Yes, that is the restriction.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants