Improve defer-failures
#107
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, all deferred failures had the same generic error message, and we could only see the real failure by removing `defer-failures` and performing other steps that were described in the README. Now we preserve the real message and there is no reason to disable `defer-failures` during testing.
Expected failure tests now only succeed if the error message matches what we expect. This also enables us to address #45 down the road.
|
Nevermind – apparently this was a transient failure. |
Now that we can debug property tests with `defer-failures`, we can also run the tests in parallel, which is faster.`
It hasn’t been needed since GHC 8.4 support was removed (where it allowed us to centralize `CPP` usage). So now just declare the `TestCategory` directly everywhere.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
defer-failuresnow preserves the original error message, and we can check that message in test cases. There is no longer any need to disabledefer-failures(or jump through the other hoops previously listed in the README) in order to debug test failures.This also enables us to address #45.