-
Notifications
You must be signed in to change notification settings - Fork 2k
Add ifc open shell recipe #27623
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Add ifc open shell recipe #27623
Conversation
cb1ae66
to
cb89b0f
Compare
cb89b0f
to
447364a
Compare
8dd9c1b
to
61f1900
Compare
Hey. A hint: don't forget to patch add_debug_variants(...) calls ( line 370, 471 and 587 on CMakeLists) as they cause failure with Visual Studio generators. I'll try to support you whenever I find some time (and, ofc, if you need :) ) Great effort, thanks in advance! |
61f1900
to
ac6c681
Compare
ac6c681
to
27901e8
Compare
Hi @ecoezen , thanks for your feedback, are you a IfcOpenShell user? which I don't explain and personaly my workstation is on Linux. Also for Mac platform I have a "Undefined symbols for architecture arm64" error which I don't explain no more. Regards. |
Hey. I actually sent you a pr yesterday—explains exactly that: EstebanDugueperoux2#12 "/permissive- fixes a build failure in MSVC when using alternate operators (&&:and - ||:or) (in IfcOffsetCurveByDistance.cpp). Could be worked around by including in C++17, but it’s removed in C++20+" So, there are 3 ways to fix the error. Replace and/or keywords with classical operators in IfcOffsetCurveByDistance.cpp as source patch. Second, patch IfcOffsetCurveByDistance.cpp to include ciso646 header. Third, set conformance mode permissive- flag. But all these workarounds are only required when below cpp20. You may also receive a compilation error about exception handling, set eHsc to observe solution. |
It seems the same error appears on macos ci as well (and probably only when building with cpp17 and below). If so, the best solution would be patch IfcOffsetCurveByDistance.cpp to include ciso646 header when building with cpp17 and below. |
hey again @EstebanDugueperoux2 . seems like it resolves failures on windows build. you might need to update test_package.cpp (you may use the one in EstebanDugueperoux2#12) also, would you be okay me to contribute and push to directly on your branch later today--when i got some time? |
950c7f2
to
827dcb3
Compare
Hi @ecoezen, Regards. |
Hi @AbrilRBS, Do you know why Linux builds take such time? Regards. |
@EstebanDugueperoux2 the builds were stopped after the failures in the other configurations, but Jenkins was a bit too eager and did not wait for the jobs to submit the update that they were being cancelled to the github check suite |
c58a8ba
to
b27323e
Compare
9264538
to
13d70b7
Compare
13d70b7
to
e695c16
Compare
Summary
Changes to recipe: lib/[version]
Motivation
Details