Skip to content

Add ifc open shell recipe #27623

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

EstebanDugueperoux2
Copy link
Contributor

Summary

Changes to recipe: lib/[version]

Motivation

Details


@EstebanDugueperoux2 EstebanDugueperoux2 force-pushed the AddIfcOpenShellRecipe branch 2 times, most recently from cb1ae66 to cb89b0f Compare June 9, 2025 07:19
valgur added a commit to valgur/conan-center-index that referenced this pull request Jun 9, 2025
@EstebanDugueperoux2 EstebanDugueperoux2 force-pushed the AddIfcOpenShellRecipe branch 10 times, most recently from 8dd9c1b to 61f1900 Compare June 9, 2025 21:41
@ecoezen
Copy link

ecoezen commented Jun 9, 2025

Hey. A hint: don't forget to patch add_debug_variants(...) calls ( line 370, 471 and 587 on CMakeLists) as they cause failure with Visual Studio generators. I'll try to support you whenever I find some time (and, ofc, if you need :) )

Great effort, thanks in advance!

@EstebanDugueperoux2
Copy link
Contributor Author

EstebanDugueperoux2 commented Jun 11, 2025

Hi @ecoezen , thanks for your feedback, are you a IfcOpenShell user?
Currently I have random error for Windows platform about cpp syntax errors on IfcOffsetCurveByDistance (https://c3i.jfrog.io/artifactory/cci-build-logs/cci/prod/PR-27623/17/package_build_logs/build_log_ifcopenshell_0_8_2_cci_20250407_67c5eb8d395510ea87b1de553fde0400_4f41b621d54c4fb83dd818c90e0b754f4d378c3f.txt)

which I don't explain and personaly my workstation is on Linux.

Also for Mac platform I have a "Undefined symbols for architecture arm64" error which I don't explain no more.

Regards.

@ecoezen
Copy link

ecoezen commented Jun 11, 2025

Hey. I actually sent you a pr yesterday—explains exactly that: EstebanDugueperoux2#12

"/permissive- fixes a build failure in MSVC when using alternate operators (&&:and - ||:or) (in IfcOffsetCurveByDistance.cpp). Could be worked around by including in C++17, but it’s removed in C++20+"

So, there are 3 ways to fix the error. Replace and/or keywords with classical operators in IfcOffsetCurveByDistance.cpp as source patch. Second, patch IfcOffsetCurveByDistance.cpp to include ciso646 header. Third, set conformance mode permissive- flag. But all these workarounds are only required when below cpp20.

You may also receive a compilation error about exception handling, set eHsc to observe solution.

@ecoezen
Copy link

ecoezen commented Jun 11, 2025

Hi @ecoezen , thanks for your feedback, are you a IfcOpenShell user?
Currently I have random error for Windows platform about cpp syntax errors on IfcOffsetCurveByDistance (https://c3i.jfrog.io/artifactory/cci-build-logs/cci/prod/PR-27623/17/package_build_logs/build_log_ifcopenshell_0_8_2_cci_20250407_67c5eb8d395510ea87b1de553fde0400_4f41b621d54c4fb83dd818c90e0b754f4d378c3f.txt)

which I don't explain and personaly my workstation is on Linux.

Also for Mac platform I have a "Undefined symbols for architecture arm64" error which I don't explain no more.

Regards.

It seems the same error appears on macos ci as well (and probably only when building with cpp17 and below). If so, the best solution would be patch IfcOffsetCurveByDistance.cpp to include ciso646 header when building with cpp17 and below.

@ecoezen
Copy link

ecoezen commented Jun 11, 2025

hey again @EstebanDugueperoux2 . seems like it resolves failures on windows build. you might need to update test_package.cpp (you may use the one in EstebanDugueperoux2#12)

also, would you be okay me to contribute and push to directly on your branch later today--when i got some time?

@EstebanDugueperoux2
Copy link
Contributor Author

Hi @ecoezen,
yes you can propose PR to target my branch but it seems there are too many changes on EstebanDugueperoux2#12.
I'll open a issue on ifcopenshell project to talk about conan recipe contribution and propose changes directly to ifcopenshell to avoid patch in our recipe.

Regards.

@EstebanDugueperoux2
Copy link
Contributor Author

Hi @AbrilRBS,

Do you know why Linux builds take such time?
We have no visibility on logs.

Regards.

@AbrilRBS
Copy link
Member

@EstebanDugueperoux2 the builds were stopped after the failures in the other configurations, but Jenkins was a bit too eager and did not wait for the jobs to submit the update that they were being cancelled to the github check suite

@EstebanDugueperoux2 EstebanDugueperoux2 force-pushed the AddIfcOpenShellRecipe branch 2 times, most recently from c58a8ba to b27323e Compare June 12, 2025 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants