Skip to content

robin-hood-hashing: fix missing include #27631

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

planetmarshall
Copy link
Contributor

Summary

Changes to recipe: robin-hood-hashing/3.11.5

Motivation

Build fails with GCC 15

Details

patch missing include


Copy link
Member

@AbrilRBS AbrilRBS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for providing this PR

I'm accepting this as the change is trivial and can not cause issues, but please note that this library is no longer maintained, and moving forward we will not be maintaing it

(Today it's a single header, but as new compilers are released, the code will get getting more "oudated" and we can't commit to support these kinds of fixes forever)

Note that as per the upstream deprecation notice, https://github.com/martinus/unordered_dense is the recommended replacement for this library from the same author, so it's possible that in the future we'll mark this as deprecated and point to the new recipe

@AbrilRBS AbrilRBS merged commit 3d2b63c into conan-io:master Jun 12, 2025
8 checks passed
@planetmarshall
Copy link
Contributor Author

planetmarshall commented Jun 12, 2025

I'm accepting this as the change is trivial and can not cause issues, but please note that this library is no longer maintained, and moving forward we will not be maintaing it

It was vulkan-validationlayers that depended on this recipe. Looking at the sources for that package, they have deprecated it in favour of parallel-hashmap. I'll put a comment in #27460

@planetmarshall planetmarshall deleted the robin-hood-hashing-missing-include branch June 12, 2025 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants