fbgemm: add new recipe (v1.3.0) #29177
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
czoido
reviewed
Dec 18, 2025
recipes/fbgemm/all/conanfile.py
Outdated
| check_min_cppstd(self, 17) | ||
| if self.settings.get_safe("compiler.cstd"): | ||
| check_min_cstd(self, 99) | ||
| if "arm" in self.settings.arch or self.settings.arch == "x86": |
Contributor
There was a problem hiding this comment.
Are you sure this is true? I can see conditionals for arm in the library's CMakeLists.txt: https://github.com/pytorch/FBGEMM/blob/c93ec6e3b57f01ffd94335cef11c807430a836ca/CMakeLists.txt#L166
czoido
reviewed
Dec 19, 2025
AbrilRBS
reviewed
Dec 19, 2025
Comment on lines
+49
to
+50
| if "arm" in self.settings.arch: | ||
| raise ConanInvalidConfiguration("fbgemm is not supported on ARM") |
Member
There was a problem hiding this comment.
I think we can remove this restriction
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changes to recipe: fbgemm/1.3.0
Motivation
As part of the devendorization process of
libtorchdependencies, this recipe was not yet included in CCI and it is already present in several distributions, see repology.Details
Straightforward library:
cpuinfoandasmjit(both withtransitive_headersand libs enabled as they are used in the public headers)-WerrorfbgemmLibraryand the official CMake target isfbgemmOpenMPso pertinent compiler flags should be added ingccandclangasmsvcdefaults link against itAdd a 👍 reaction to pull requests you find important to help the team prioritize, thanks!