-
Notifications
You must be signed in to change notification settings - Fork 2.2k
cairo: add 1.18.4 #29196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
cairo: add 1.18.4 #29196
Conversation
|
The pixman update in here is required, I submitted it back in July in #27867. There are quite a bunch of references to various minor versions of cairo. Might want to bump them all to latest and stop publishing the old ones, but that's for the Conan team to decide, I'm just submitting the new version here regardless: |
|
Mhm, I've been building without freetype locally, will look into the CI failure. (Edit: Fixed, there was some hackery that had a FreeType min version hardcoded, which changed with this release. Updated it depending on what version is being built.) |
5a571b9 to
d76373b
Compare
|
|
||
| def requirements(self): | ||
| self.requires("pixman/0.43.4") | ||
| self.requires("pixman/0.46.2") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mologie Hello! Do you have evidence that bumping for Pixman is needed? As far as I see, Cairo only needs Pixman >=0.40: https://gitlab.freedesktop.org/cairo/cairo/-/blob/master/meson.build?ref_type=heads#L636
I have a PR to update GTK, which requires a newer version of Cairo, so I bumped to 1.18.4 as well: https://github.com/conan-io/conan-center-index/pull/29172/changes#diff-5fbc6d75ac2a534cc5331a7d03445181fd9361da70cbbe9fb23873f06f5cc023. But I did not need to bump pixman to make it work: https://github.com/conan-io/conan-center-index/pull/29172/checks?check_run_id=58714887302. Maybe I'm missing something.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@uilianries Hi! I had trouble cross-compiling this older release for ARM, and updating resolved it. I don't believe this was anything specific to this Cairo update in particular, but this combination of Pixman and Cairo works nicely for me on arm32 and arm64 (whereas the old one did not).
This was half a year ago fwiw, I do not have the build env anymore, but can start digging if specific details are needed.
Summary
Changes to recipe: cairo/1.18.4
Motivation
This adds the latest upstream release 1.18.4 from beginning of this year.
Add a 👍 reaction to pull requests you find important to help the team prioritize, thanks!