hdf5: Add release 2.0.0 #29199
Open
hdf5: Add release 2.0.0 #29199
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EstebanDugueperoux2
force-pushed
the
AddHDF5_2.0
branch
from
eb2876d to
cd3f762
Compare
EstebanDugueperoux2
force-pushed
the
AddHDF5_2.0
branch
from
cd3f762 to
fe97c0a
Compare
AbrilRBS
reviewed
Dec 23, 2025
Member
AbrilRBS
left a comment
AbrilRBS
left a comment
There was a problem hiding this comment.
This recipe will need more changes before the new version is merged.
Of the top of my review, the most important things that showed up are:
- We need cmake 3.26 as a minimum for this newer version
- It's clear that zlib support has not been tested for the new version, because enabling it has no effect as-is. Note that the new option that controls it is
HDF5_ENABLE_ZLIB_SUPPORTinstead of the already existing one. I'm guessing this is not the only change necessary to get the dependencies working for this new release, and that the changes to the options go beyond just zlib
We're happy to help where needed, but it would be great if we could have clear guidance of what was tested/reviewed locally before adding a new major version of the recipe
Contributor
Author
|
Hi @AbrilRBS, Locally, on my ubuntu workstation, I have only test static and shared builds. Regards. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changes to recipe: hdf5/2.0.0
Motivation
Details
Add a 👍 reaction to pull requests you find important to help the team prioritize, thanks!