onnxruntime: trying to use onnx with shared=True #29231
Open
+4
−7
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After submitting #29205, ORT now compiles with
onnx:shared=True, but it raises another bug when something links with the library:Reviewing the ONNX implementation,
onnxis linking withonnx_proto_objecttoo (https://github.com/onnx/onnx/blob/v1.20.0/CMakeLists.txt#L459), so I think that we can removeonnx_protoas an external dependency to avoid that error.Add a 👍 reaction to pull requests you find important to help the team prioritize, thanks!