Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom deployer for metadata example #3589

Open
wants to merge 2 commits into
base: release/2.1
Choose a base branch
from

Conversation

AbrilRBS
Copy link
Member

@AbrilRBS AbrilRBS commented Feb 15, 2024

Copy link
Member

@memsharded memsharded left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs some further elaboration, because the very common case in which users will want to gather metadata from servers, is not covered by this.

Probably we need to make sure how it looks like in a test first, the UX etc.

@@ -340,7 +340,8 @@ downloading it, and copying it to our current folder:

.. seealso::

- TODO: Examples how to collect the metadata of a complete dependency graph with some custom deployer or command
- Check an :ref:`example on how to collect the metadata of a complete dependency graph with some custom deployer<examples_extensions_deployers_metadata>`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The challenge with this example is that there will be issues with users expectations:

  • conan install will install dependencies, but it will not install metadata from the servers
  • Then the metadata is NOT in the Conan cache
  • Gathering the metadata will not collect anything, only metadata that has been created locally.

The solution is that the metadata has to be downloaded from the server with conan download --metadata explicitly first, then collected.

@czoido czoido modified the milestones: 2.1.0, 2.2.0, 2.3.0 Mar 19, 2024
@czoido czoido modified the milestones: 2.3.0, 2.4.0 May 8, 2024
@czoido czoido modified the milestones: 2.4.0, 2.5.0 Jun 4, 2024
@czoido czoido modified the milestones: 2.5.0, 2.6.0 Jul 2, 2024
@czoido czoido modified the milestones: 2.6.0, 2 Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants