Add warning about not having conditional source methods #3773
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
memsharded
reviewed
Jun 13, 2024
| .. note:: | ||
|
|
||
| The ``source()`` method _MUST NOT_ be conditional to any configuration, so it should be the same for all configurations. | ||
| Settings and options access is disallowed in this method, and recipes should not set any conditionals based on the platform either |
There was a problem hiding this comment.
Maybe we can relax and suggest that platform.system and similar can be used at the responsibility of users and knowing it will not be cross-platform, etc? Because this is kind of a bad thing, but it sometimes happen
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thinking ahout adding some information to let users know that they have the alternative approach of using the build() method if needed