Colour code like Conan 1 docs, ensure highlight works#3779
Open
AbrilRBS wants to merge 1 commit intoconan-io:develop2from
Open
Colour code like Conan 1 docs, ensure highlight works#3779AbrilRBS wants to merge 1 commit intoconan-io:develop2from
AbrilRBS wants to merge 1 commit intoconan-io:develop2from
Conversation
memsharded
approved these changes
Jun 20, 2024
Member
memsharded
left a comment
memsharded
left a comment
There was a problem hiding this comment.
Looks good, so finally no light orange, but the most standard light green? Did this already changed in Conan 1 docs? It seems so.
Contributor
|
What about using
|
Contributor
|
this should go to master to regenerate all the branches |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After talking with @memsharded, this colour scheme looks nicer, it's more prominent to the user that they are reading code
The only thing I'm not completely sold on is the highlight colour. I'm open to suggestions! :)
Also, this will only work for the new 2.5 release. Should we backport this to at least 2.4?