Add new authenticator required action #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s-token instead of logs
…ernal dependencies.
…d-new-authenticator-required-action
…d-new-authenticator-required-action # Conflicts: # pom.xml
|
@sventorben please take a look. I added some documentation. |
sventorben
requested changes
Oct 7, 2024
| @@ -0,0 +1,19 @@ | |||
| # Authenticator-Required-Action | |||
|
|
|||
There was a problem hiding this comment.
I think you should add a general description of what problem or use case this authenticator is good for. Just starting with an example out of context does not really help to understand what it is doing.
There was a problem hiding this comment.
Please check if that is sufficent.
...t/java/de/conciso/keycloak/authentication/required_action/RequiredActionAuthenticatorIT.java
Outdated
Show resolved
Hide resolved
|
|
||
| @Override | ||
| public void authenticate(AuthenticationFlowContext context) { | ||
| context.getUser().addRequiredAction( |
There was a problem hiding this comment.
It would be good if we could make this more robust to configuration errors, e.g. what if no authenticator config exists, or what if the key is not present in the config, or the configured required action does not exist.
There was a problem hiding this comment.
I will look into it.
|
@sventorben please take a look again. |
sventorben
approved these changes
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added Authenticator that sets a specific RequiredAction for the authenticating User