-
-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide linux-anvil-cuda
on x64 with RHEL 8, distinguish distro baseline in tag
#291
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Axel! 🙏
Generally this seems reasonable
In the past when upgrading from CentOS 6 to 7, we added new images that were named linux-anvil-cos7-cuda
( #167 ). Am thinking it would make sense to do the same thing here and add linux-anvil-ubi8-cuda
. Effectively this is just one more image (as the others are already on UBI 8)
Thinking this would minimize surprise for users as they would continue to get the same OS versions with the same image names (as they may have come to expect)
Admittedly CentOS 7 support is rolling off ( conda-forge/cuda-feedstock#28 ). So we may end up dropping the old image at that time
Thanks for the review!
For the alma and CUDA images, we've been moving to image tags per distro version, which I think is more elegant. I don't want to go back to including the distro in the image name (I don't mind putting it in tag though, if we really want to keep a cos7 variant selectable).
I was surprised to see that the image version (and distro) did not align for the cuda images between x64 resp. aarch/ppc, so I don't think there are many expectations of that sort (as the current situation is already inconsistent/confusing, and the image version doesn't matter in any practical sense since everything is based on the PS. We've been waiting for ~2 weeks for a response from you in #287, please have a look at that PR as well. 🙏 |
linux-anvil-cuda
to use RHEL 8 baselinelinux-anvil-cuda
on x64 to use RHEL 8 baseline
@jakirkham, if you'd like to make the distro-version selectable for the CUDA 11.8 images, I have a proposal for how this could look like in #293; if we decide not to encode the distro version (which is completely fine IMO, as it's effectively irrelevant, c.f. conda-forge/conda-forge-pinning-feedstock#6283), then this PR is ready. |
This now incorporates the discussion from #291, in particular, the move of the distroname into the tag, in order to support choosing this where necessary (e.g. for feedstocks that do binary repackaging). |
linux-anvil-cuda
on x64 to use RHEL 8 baselinelinux-anvil-cuda
on x64 with RHEL 8, distinguish distro baseline in tag
The other two architectures are already on UBI 8
For conda-forge/conda-forge.github.io#1941 / conda-forge/conda-forge-pinning-feedstock#6283
Check out the available tags; the required
-devel-{distro}
is only available for ppc if we use ubi8, so might as well use that distro for all architectures.