Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide linux-anvil-cuda on x64 with RHEL 8, distinguish distro baseline in tag #291

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

h-vetinari
Copy link
Member

@h-vetinari h-vetinari commented Oct 29, 2024

The other two architectures are already on UBI 8

For conda-forge/conda-forge.github.io#1941 / conda-forge/conda-forge-pinning-feedstock#6283

Check out the available tags; the required -devel-{distro} is only available for ppc if we use ubi8, so might as well use that distro for all architectures.

Copy link
Member

@jakirkham jakirkham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Axel! 🙏

Generally this seems reasonable

In the past when upgrading from CentOS 6 to 7, we added new images that were named linux-anvil-cos7-cuda ( #167 ). Am thinking it would make sense to do the same thing here and add linux-anvil-ubi8-cuda. Effectively this is just one more image (as the others are already on UBI 8)

Thinking this would minimize surprise for users as they would continue to get the same OS versions with the same image names (as they may have come to expect)

Admittedly CentOS 7 support is rolling off ( conda-forge/cuda-feedstock#28 ). So we may end up dropping the old image at that time

.github/workflows/ci.yaml Outdated Show resolved Hide resolved
.github/workflows/ci.yaml Show resolved Hide resolved
@h-vetinari
Copy link
Member Author

Thanks for the review!

In the past when upgrading from CentOS 6 to 7, we added new images that were named linux-anvil-cos7-cuda ( #167 ). Am thinking it would make sense to do the same thing here and add linux-anvil-ubi8-cuda.

For the alma and CUDA images, we've been moving to image tags per distro version, which I think is more elegant. I don't want to go back to including the distro in the image name (I don't mind putting it in tag though, if we really want to keep a cos7 variant selectable).

Thinking this would minimize surprise for users as they would continue to get the same OS versions with the same image names (as they may have come to expect)

I was surprised to see that the image version (and distro) did not align for the cuda images between x64 resp. aarch/ppc, so I don't think there are many expectations of that sort (as the current situation is already inconsistent/confusing, and the image version doesn't matter in any practical sense since everything is based on the sysroot version). So I consider this a negligible risk, especially as all our infra will soon move to RHEL8-based images anyway.

PS. We've been waiting for ~2 weeks for a response from you in #287, please have a look at that PR as well. 🙏

@h-vetinari h-vetinari changed the title Update linux-anvil-cuda to use RHEL 8 baseline Update linux-anvil-cuda on x64 to use RHEL 8 baseline Oct 31, 2024
@h-vetinari
Copy link
Member Author

@jakirkham, if you'd like to make the distro-version selectable for the CUDA 11.8 images, I have a proposal for how this could look like in #293; if we decide not to encode the distro version (which is completely fine IMO, as it's effectively irrelevant, c.f. conda-forge/conda-forge-pinning-feedstock#6283), then this PR is ready.

@h-vetinari
Copy link
Member Author

This now incorporates the discussion from #291, in particular, the move of the distroname into the tag, in order to support choosing this where necessary (e.g. for feedstocks that do binary repackaging).

@h-vetinari h-vetinari changed the title Update linux-anvil-cuda on x64 to use RHEL 8 baseline Provide linux-anvil-cuda on x64 with RHEL 8, distinguish distro baseline in tag Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants