Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Matplotlib 3.9.1 #390

Merged
merged 104 commits into from
Jul 8, 2024
Merged

Matplotlib 3.9.1 #390

merged 104 commits into from
Jul 8, 2024

Conversation

tacaswell
Copy link
Contributor

Attempt to merge the rc branch to main.

conda-forge-curator bot and others added 30 commits March 15, 2024 19:07
Co-authored-by: jakirkham <[email protected]>
@beckermr
Copy link
Member

beckermr commented Jul 1, 2024

We used cos6 like this for a long time and had no issues so fun!

@jakirkham jakirkham mentioned this pull request Jul 1, 2024
5 tasks
@jakirkham
Copy link
Member

jakirkham commented Jul 1, 2024

Maybe we can use a different mirror source?

Looks like UC Irvine maintains one and it goes back quite a bit: https://mirrors.oit.uci.edu/centos/ (though that looks like it is missing something)

Alternatively we do the same thing we did with CentOS 6 and switch to the vault mirrors

@jakirkham
Copy link
Member

Looks like @isuruf started a PR for the latter: conda-forge/docker-images#271

@jakirkham
Copy link
Member

We have since deployed a fix

Restarting failed CI builds to see if these issues clear up

@jakirkham
Copy link
Member

Looks like it is passing! 🥳

@xhochy
Copy link
Member

xhochy commented Jul 4, 2024

There is already a 3.9.0 build uploaded to conda-forge. Should that be marked broken? Where did that come from?

@fhoehle
Copy link
Member

fhoehle commented Jul 4, 2024

There is already a 3.9.0 build uploaded to conda-forge. Should that be marked broken? Where did that come from?

IIUC: There is a rc branch in this feedstock which successfully built it: CI run and PR and final commit

@h-vetinari
Copy link
Member

The rc branch needs to have something like the following in recipe/conda_build_config.yaml:

channel_targets:
  - conda-forge matplotlib_rc

and then rerender.

@xhochy
Copy link
Member

xhochy commented Jul 4, 2024

Filed a PR here: #392

@tacaswell tacaswell marked this pull request as draft July 4, 2024 16:20
@tacaswell
Copy link
Contributor Author

ah, I was wondering how the 3.9.0 files ended up on the main channel, we must have lost that config while trying to get the builds to work at all. We just did a 3.9.1 so moved this to draft until I get that updated.

@tacaswell tacaswell marked this pull request as ready for review July 5, 2024 13:56
@tacaswell tacaswell mentioned this pull request Jul 5, 2024
3 tasks
@tacaswell tacaswell changed the title Matplotlib 3.9.0 Matplotlib 3.9.1 Jul 5, 2024
@tacaswell
Copy link
Contributor Author

Looks like azure has decided to not run in parallel....

@xhochy
Copy link
Member

xhochy commented Jul 5, 2024

See conda-forge/status#181

@akrherz
Copy link

akrherz commented Jul 6, 2024

@conda-forge-admin please restart ci

@tacaswell tacaswell merged commit 57c44c2 into conda-forge:main Jul 8, 2024
37 checks passed
@tacaswell tacaswell deleted the v390 branch July 8, 2024 13:50
@jobovy
Copy link
Member

jobovy commented Jul 10, 2024

Version 3.9.1 doesn't seem to have made it to the conda-forge channel, even though it seems like it should have? conda search matplotlib -c conda-forge still lists 3.8.4 as the latest version and the conda-forge/matplotlib website doesn't have 3.9.1 either (even though the more recent matplotlib_rc labeled version from #392 was uploaded there). In my tests, I'm hitting DeprecationWarning: backend2gui is deprecated since IPython 8.24, backends are managed in matplotlib and can be externally registered. due to (I think) a conflict between the latest IPython 8.26.0 and matplotlib 3.8.4 that seems to be resolved in 3.9.0 (I think resulting from this PR: matplotlib/matplotlib#27948). I can get rid of this by pip installing 3.9.1, but would prefer to use the conda version. Thanks!

@larsoner
Copy link
Contributor

Looking at the main branch builds I don't see an entry for this PR's merge:

https://dev.azure.com/conda-forge/feedstock-builds/_build?definitionId=617&_a=summary&repositoryFilter=605&branchFilter=211331

No idea why that would happen. Maybe we could bug the conda-forge folks about this (?) but as a naive attempted solution I'll open a blank PR that someone could merge if they wanted and we could see if that fixes things.

@larsoner larsoner mentioned this pull request Jul 10, 2024
5 tasks
@h-vetinari
Copy link
Member

Looking at the main branch builds I don't see an entry for this PR's merge:

The interop between github and azure pipelines is fragile; though it works 99+% of the time, there is stuff that breaks, one of them being the case here (no CI started after merge). In this scenario, if you're a regular maintainer, you could do

git checkout main  # make sure it's up to date
git commit --allow-empty -m "retrigger CI"
git push upstream main  # or whatever you named the remote corresponding to the feedstock

In case someone from core with access to our azure organisation is around, they can start it manually without that extra commit, which is what I've done now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.