-
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stop using CDTs for OpenGL and run render test when Python tests are run #66
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
We were able to reproduce the failures that we saw in conda-forge/gymnasium-feedstock#41 . Windows and osx are failing, while Linux is hanging. |
osx error:
Windows error:
|
@conda-forge-admin please rerender |
…nda-forge-pinning 2024.10.22.07.05.02
@@ -30,7 +30,7 @@ source: | |||
build: | |||
# See https://github.com/conda-forge/mujoco-feedstock/issues/22 | |||
skip: true # [(aarch64 or ppc64le or osx) and python_impl == 'pypy'] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you want, you can get rid of that skip and all traces of pypy/python_impl
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I plan to do that in a follow up PR, thanks!
mujoco
should have full support for headless rendering, so I guess rendering tests should pass fine also in CI. This is important to ensure that testing of downstream libraries (such as conda-forge/gymnasium-feedstock#41) assume that mujoco render works in CI.This PR also:
CDTs
and just use the glvnd-basedlibgl-devel
to provide OpenGL on Linuxmesalib
and setMUJOCO_GL=osmesa
to pass render tests on Linux as the EGL driver available on centos7 (the images used in CI) have some problems. In [v9] Enable tests gz-rendering-feedstock#35 we switched to use a newer docker images to avoid problems, but in the mujoco case installingmesalib
and setMUJOCO_GL=osmesa
is probably the easier solution.MUJOCO_GL=osmesa
is not supported as it is explicitly not allowed in https://github.com/google-deepmind/mujoco/blob/3.2.4/python/mujoco/gl_context.py#L22 and macos and Windows-specific code for handling osmesa is missing in https://github.com/google-deepmind/mujoco/blob/3.2.4/src/render/glad/glad.c#L226-L244 and https://github.com/google-deepmind/mujoco/blob/3.2.4/src/render/glad/glad.c#L88-L97 . So, as done in upstream CI, so we skip rendering tests there by settingMUJOCO_GL=disable
.Checklist
0
(if the version changed)conda-smithy
(Use the phrase@conda-forge-admin, please rerender
in a comment in this PR for automated rerendering)