Skip to content

Disable automerge #104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 23, 2025
Merged

Disable automerge #104

merged 5 commits into from
May 23, 2025

Conversation

traversaro
Copy link
Contributor

@traversaro traversaro commented Sep 22, 2024

Given all the problems occurring in new pybind11 releases related to abi changes (see #95) perhaps it could make sense to disable automerge here so that new versions can at least be checked before merging?

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

@traversaro
Copy link
Contributor Author

@conda-forge-admin please rerender

@conda-forge-admin
Copy link
Contributor

conda-forge-admin commented Dec 2, 2024

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe/meta.yaml:

  • ℹ️ The recipe is not parsable by parser conda-souschef (grayskull). Your recipe may not receive automatic updates and/or may not be compatible with conda-forge's infrastructure. Please check the logs for more information and ensure your recipe can be parsed.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/12118772517. Examine the logs at this URL for more detail.

@traversaro
Copy link
Contributor Author

I refreshed this PR as all the changes in pybind/pybind11#4953 and pybind/pybind11#5439 will require to revise the pybind11-abi package. However, after I opened it I noticed that the pybind11-abi package output was disabled in #108, so this is much less urgent, even if it would be great if we could solve rethink the pybind11-abi meta-package during the packaging of the new pybind11 release, as it is quite used across conda-forge: https://github.com/search?q=org%3Aconda-forge%20pybind11-abi&type=code .

The re-rendering does not change the content of the package, so I think we can avoid bump the build number.

@traversaro
Copy link
Contributor Author

@conda-forge/pybind11 the PR is ready for review/discussion.

@traversaro
Copy link
Contributor Author

@conda-forge/pybind11 the PR is ready for review/discussion.

Any feedback on this? This does not change anything in the package, it just want to make sure that we do the the required modifications to account for pybind/pybind11#4953 and pybind/pybind11#5439 once the new version of pybind11 is getting released. If it helps and you like it, I can work add myself as a maintainer in the feedstock.

@henryiii henryiii added bot-rerun Instruct the bot to retry the PR and removed bot-rerun Instruct the bot to retry the PR labels May 22, 2025
@henryiii
Copy link
Contributor

@conda-forge-admin, please rerender

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I was trying to look for recipes to lint for you, but it appears we have a merge conflict. Please try to merge or rebase with the base branch to resolve this conflict.

Please ping the 'conda-forge/core' team (using the @ notation in a comment) if you believe this is a bug.

@henryiii
Copy link
Contributor

@conda-forge-admin, please rerender

@conda-forge-admin
Copy link
Contributor

conda-forge-admin commented May 23, 2025

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe/meta.yaml:

  • ℹ️ The recipe is not parsable by parser conda-souschef (grayskull). This parser is not currently used by conda-forge, but may be in the future. We are collecting information to see which recipes are compatible with grayskull.
  • ℹ️ pybind11 output has some malformed specs:
  • In section run: pybind11-global PKG_VERSION=*_PKG_BUILDNUM
    Requirement spec fields should match the syntax name [version [build]]to avoid known issues in conda-build. For example, instead of name =version=build, use name version.* build. There should be no spaces between version operators and versions either: python >= 3.8 should be python >=3.8.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/15202073914. Examine the logs at this URL for more detail.

@henryiii henryiii merged commit eadc348 into conda-forge:main May 23, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants