Skip to content

Feat/windows ci runner #242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 21 commits into from
Closed

Conversation

wolfv
Copy link
Member

@wolfv wolfv commented Jun 21, 2024

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I was trying to look for recipes to lint for you, but it appears we have a merge conflict.
Please try to merge or rebase with the base branch to resolve this conflict.

Please ping the 'conda-forge/core' team (using the @ notation in a comment) if you believe this is a bug.

@aktech
Copy link

aktech commented Jun 21, 2024

Thanks for creating this I was just about to work on creating this one.

@wolfv wolfv force-pushed the feat/windows-ci-runner branch from 47b9d47 to 900b84b Compare June 21, 2024 09:10
@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

  • Selectors are suggested to take a <two spaces>#<one space>[<expression>] form. See lines [110, 111, 149, 220, 221, 258]

For recipe:

  • It looks like the 'libtorch' output doesn't have any tests.

@wolfv
Copy link
Member Author

wolfv commented Jun 21, 2024

Sure thing! Rebasing was actually a bit painful :)

Any idea why cirun is failing? Did I use the wrong label?

@aktech
Copy link

aktech commented Jun 21, 2024

The error is: No runners configuration found after labels filtering

The workflow is requesting labels: x64, cirun-azure-windows-2xlarge, windows. The x64 is missing from here: https://github.com/conda-forge/.cirun/blob/b2aeabf22170179a4eb17f3f3c1e4eb45580e142/.cirun.global.yml#L127 I've just created a PR now: conda-forge/.cirun#15

@wolfv
Copy link
Member Author

wolfv commented Jun 21, 2024

Great. Should I push an empty commit to trigger?

@aktech
Copy link

aktech commented Jun 21, 2024

Yes, that should work.

@wolfv
Copy link
Member Author

wolfv commented Jun 21, 2024

Alright, I triggered!

@wolfv
Copy link
Member Author

wolfv commented Jun 21, 2024

still not starting, any ideas @aktech ? :)

@aktech
Copy link

aktech commented Jun 21, 2024

Yep, investigating

@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

  • Selectors are suggested to take a <two spaces>#<one space>[<expression>] form. See lines [110, 111, 149, 220, 221, 258]
  • There are too few lines. There should be one empty line at the end of the file.

For recipe:

  • It looks like the 'libtorch' output doesn't have any tests.

@hmaarrfk
Copy link
Contributor

sorry again for the conflicts.

@baszalmstra
Copy link
Member

I incorporated all you changes in #231 I think we can close this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants