-
-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NEW: Add default values for cuda_compiler on osx and windows #27547
Conversation
Hi! This is the friendly automated conda-forge-linting service. I was trying to look for recipes to lint for you, but couldn't find any. |
Hi! Thanks for your contribution to conda-forge. We appreciate your effort in improving our project. However, it looks like some changes were made outside the If these changes are intentional (and you aren't submitting a recipe), please attach a Thanks! |
Or did you want something like this: {% if cuda_compiler_version in (None, "None", True, False) %}
{% set cuda_major = 0 %}
{% else %}
{% set cuda_major = environ.get("cuda_compiler_version", "11.8").split(".")[0] | int %}
{% endif %} added to the recipes? |
we should ask @jakirkham or someone who knows the cuda stack better on @conda-forge/core |
I'm going to merge now and ask for @jakirkham's opinion later because I believe he's out of the office. |
|
This might be the wrong solution, but this is what we are trying to fix. |
IMHO, we shouldn't have to do that because this recipe is CUDA only, so the cuda compiler version should be defined. |
We should separate the issues out. Let's push an immediate fix to unblock staged recipes by using the current way cuda is done. We can discuss changes to how cuda is done as another issue. |
Sorry for the slow reply. As Daniel noted I was out for some time Likely the issue that was encountered is the same one we have seen elsewhere with Recently Michael fixed this error in PR ( conda/conda-build#5458 ), which was included in Have tried re-rendering both recipes locally using PR ( #26580 )'s merge commit ( 8d2e5e3 ) and |
Fixing broken feedstock rendering from #26580
@beckermr, is this what you mean? The pinnings here always lag behind the channel-wide pinnings.
https://github.com/conda-forge/admin-requests/actions/runs/10816201902
Checklist
url
) rather than a repo (e.g.git_url
) is used in your recipe (see here for more details).