-
-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NEW: Add recipe for npp-plus #29374
base: main
Are you sure you want to change the base?
NEW: Add recipe for npp-plus #29374
Conversation
Hi! This is the staged-recipes linter and your PR looks excellent! 🚀 |
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( I do have some suggestions for making it better though... For recipes/npp+/meta.yaml:
This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/13734471757. Examine the logs at this URL for more detail. |
build: | ||
run_exports: | ||
- {{ pin_subpackage("libnpp-plus", max_pin=None) }} | ||
- {{ pin_subpackage("libnpp-plus" ~ version.split(".")[0], max_pin=None) }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is ABI compatibility policy for this library? I assume it uses libtool versioning for the library version. i.e. libraries with the same soname are ABI compatible.
- {{ pin_subpackage("libnpp-plus", max_pin=None) }} | ||
- {{ pin_subpackage("libnpp-plus" ~ version.split(".")[0], max_pin=None) }} | ||
files: | ||
- lib/stubs/*.so # [linux] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are stubs needed?
files: | ||
- lib/stubs/*.so # [linux] | ||
- lib/libnpp_plus_*.so # [linux] | ||
- include/nppPlus # [linux] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't include npp headers because there is a separate npp package. Is that correct or npp+ needs its own copy of the npp headers?
Checklist
url
) rather than a repo (e.g.git_url
) is used in your recipe (see here for more details).Fixes #29401