Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rago #29382

Draft
wants to merge 14 commits into
base: main
Choose a base branch
from
Draft

Add rago #29382

wants to merge 14 commits into from

Conversation

jgyasu
Copy link

@jgyasu jgyasu commented Mar 9, 2025

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

Copy link
Contributor

github-actions bot commented Mar 9, 2025

Hi! This is the staged-recipes linter and I found some lint.

File-specific lints and/or hints:

  • recipes/rago/meta.yaml:
    • lints:
      • The following maintainers have not yet confirmed that they are willing to be listed here: xmnlab. Please ask them to comment on this PR if they are.

@conda-forge-admin
Copy link
Contributor

conda-forge-admin commented Mar 9, 2025

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/rago/meta.yaml) and found some lint.

Here's what I've got...

For recipes/rago/meta.yaml:

  • ❌ Non noarch packages should have python requirement without any version constraints.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/13751687561. Examine the logs at this URL for more detail.

@jgyasu
Copy link
Author

jgyasu commented Mar 9, 2025

@xmnlab kindly FYI

@jgyasu jgyasu changed the title Add Recipe for Rago Add rago Mar 9, 2025
@xmnlab
Copy link
Member

xmnlab commented Mar 10, 2025

thanks @jgyasu for adding me as a maintainer!

@xmnlab
Copy link
Member

xmnlab commented Mar 10, 2025

@jgyasu I guess we will need to have two "versions" of the package, the cpu and the gpu ..

so this recipe would have 2 outputs one for cpu and the other one for gpu ... here you can see some examples about how to do that: https://github.com/conda-forge/xgboost-feedstock/blob/main/recipe/meta.yaml

@jgyasu jgyasu marked this pull request as draft March 10, 2025 06:21
Copy link
Contributor

Hi! This is the staged-recipes linter and your PR looks excellent but I have some suggestions.

File-specific lints and/or hints:

  • recipes/rago/meta.yaml:
    • hints:
      • It looks like you are submitting a multi-output recipe. In these cases, the correct name for the feedstock is ambiguous, and our infrastructure defaults to the top-level package.name field. Please add a feedstock-name entry in the extra section.

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/rago/meta.yaml) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipes/rago/meta.yaml:

  • ℹ️ Please depend on pytorch directly, in order to avoid forcing CUDA users to downgrade to the CPU version for no reason.
  • ℹ️ noarch: python recipes should usually follow the syntax in our documentation for specifying the Python version.
    • For the host section of <output 2 output, you should usually use python {{ python_min }} for the python entry.
    • For the run section of <output 2 output, you should usually use python >={{ python_min }} for the python entry.
    • For the test.requires section of <output 2 output, you should usually use python {{ python_min }} for the python entry.
    • If the package requires a newer Python version than the currently supported minimum version on conda-forge, you can override the python_min variable by adding a Jinja2 set statement at the top of your recipe (or using an equivalent context variable for v1 recipes).

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/13760536410. Examine the logs at this URL for more detail.

Copy link
Contributor

Hi! This is the staged-recipes linter and your PR looks excellent! 🚀

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/rago/meta.yaml) and found some lint.

Here's what I've got...

For recipes/rago/meta.yaml:

  • ❌ There are too few lines. There should be one empty line at the end of the file.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/13770244994. Examine the logs at this URL for more detail.

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/rago/meta.yaml) and found it was in an excellent condition.

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I failed to even lint the recipe, probably because of a conda-smithy bug 😢. This likely indicates a problem in your meta.yaml, though. To get a traceback to help figure out what's going on, install conda-smithy and run conda smithy recipe-lint --conda-forge . from the recipe directory. You can also examine the workflow logs for more detail.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/13827026420. Examine the logs at this URL for more detail.

Copy link
Contributor

Hi! This is the staged-recipes linter and your PR looks excellent but I have some suggestions.

File-specific lints and/or hints:

  • recipes/rago/meta.yaml:
    • hints:
      • It looks like you are submitting a multi-output recipe. In these cases, the correct name for the feedstock is ambiguous, and our infrastructure defaults to the top-level package.name field. Please add a feedstock-name entry in the extra section.

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/rago/meta.yaml) and found it was in an excellent condition.

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/rago/meta.yaml) and found some lint.

Here's what I've got...

For recipes/rago/meta.yaml:

  • ❌ The extra section contained an unexpected subsection name. feedstock_name is not a valid subsection name.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/13827450971. Examine the logs at this URL for more detail.

Copy link
Contributor

Hi! This is the staged-recipes linter and your PR looks excellent! 🚀

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/rago/meta.yaml) and found it was in an excellent condition.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants