-
-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add hazardous 0.1.0 #29386
base: main
Are you sure you want to change the base?
Add hazardous 0.1.0 #29386
Conversation
Hi! This is the staged-recipes linter and your PR looks excellent! 🚀 |
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/hazardous/meta.yaml:
For recipes/hazardous/meta.yaml:
This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/13764487041. Examine the logs at this URL for more detail. |
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( I do have some suggestions for making it better though... For recipes/hazardous/meta.yaml:
This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/13764580752. Examine the logs at this URL for more detail. |
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
@conda-forge-admin, please rerender |
@conda-forge-admin, please ping conda-forge/help-python |
Hi! This is the friendly automated conda-forge-webservice. I was asked to ping @conda-forge/help-python and so here I am doing that. |
host: | ||
- python {{ python_min }} | ||
- flit-core | ||
- pip |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like this package imports itself at build time. It is failing b/c it cannot find numpy:
2025-03-10T12:49:53.9647326Z File "<frozen importlib._bootstrap_external>", line 850, in exec_module
2025-03-10T12:49:53.9649758Z File "<frozen importlib._bootstrap>", line 228, in _call_with_frames_removed
2025-03-10T12:49:53.9657593Z File "/home/conda/staged-recipes/build_artifacts/hazardous_1741610934033/work/hazardous/__init__.py", line 3, in <module>
2025-03-10T12:49:53.9658079Z from ._survival_boost import SurvivalBoost
2025-03-10T12:49:53.9663969Z File "/home/conda/staged-recipes/build_artifacts/hazardous_1741610934033/work/hazardous/_survival_boost.py", line 3, in <module>
2025-03-10T12:49:53.9669194Z import numpy as np
2025-03-10T12:49:53.9671611Z ModuleNotFoundError: No module named 'numpy'
2025-03-10T12:49:53.9752585Z Preparing metadata (pyproject.toml): finished with status 'error'
2025-03-10T12:49:53.9753563Z error: subprocess-exited-with-error
You may need to add all runtime deps at build time. While that is fine for for this release, it would be nice if you could open an issue upstream to resolve this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ocefpaf, thank you for the quick response. That's interesting, I've never encountered this issue on skrub, which is another package I maintain on conda-forge. The main difference is that hazardous uses flit while skrub uses setuptools. I will try your suggestion.
While that is fine for for this release, it would be nice if you could open an issue upstream to resolve this.
Do you mean adding an issue on the staged-recipe repo?
Thanks again for your help
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you mean adding an issue on the staged-recipe repo?
No. This is an issue with the package, not conda-forge's infrastructure. You will have to add numpy to host here to workaround it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah ok got it
Checklist
url
) rather than a repo (e.g.git_url
) is used in your recipe (see here for more details).