Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hazardous 0.1.0 #29386

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

Vincent-Maladiere
Copy link

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

Copy link
Contributor

Hi! This is the staged-recipes linter and your PR looks excellent! 🚀

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/hazardous/meta.yaml) and found some lint.

Here's what I've got...

For recipes/hazardous/meta.yaml:

  • ❌ The home item is expected in the about section.
  • ❌ There are too few lines. There should be one empty line at the end of the file.

For recipes/hazardous/meta.yaml:

  • ℹ️ noarch: python recipes should usually follow the syntax in our documentation for specifying the Python version.
    • For the host section of recipe, you should usually use python {{ python_min }} for the python entry.
    • For the run section of recipe, you should usually use python >={{ python_min }} for the python entry.
    • For the test.requires section of recipe, you should usually use python {{ python_min }} for the python entry.
    • If the package requires a newer Python version than the currently supported minimum version on conda-forge, you can override the python_min variable by adding a Jinja2 set statement at the top of your recipe (or using an equivalent context variable for v1 recipes).

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/13764487041. Examine the logs at this URL for more detail.

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/hazardous/meta.yaml) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipes/hazardous/meta.yaml:

  • ℹ️ noarch: python recipes should usually follow the syntax in our documentation for specifying the Python version.
    • For the host section of recipe, you should usually use python {{ python_min }} for the python entry.
    • For the run section of recipe, you should usually use python >={{ python_min }} for the python entry.
    • For the test.requires section of recipe, you should usually use python {{ python_min }} for the python entry.
    • If the package requires a newer Python version than the currently supported minimum version on conda-forge, you can override the python_min variable by adding a Jinja2 set statement at the top of your recipe (or using an equivalent context variable for v1 recipes).

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/13764580752. Examine the logs at this URL for more detail.

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/hazardous/meta.yaml) and found it was in an excellent condition.

@Vincent-Maladiere
Copy link
Author

@conda-forge-admin, please rerender

@Vincent-Maladiere
Copy link
Author

@conda-forge-admin, please ping conda-forge/help-python

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-webservice.

I was asked to ping @conda-forge/help-python and so here I am doing that.

host:
- python {{ python_min }}
- flit-core
- pip
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this package imports itself at build time. It is failing b/c it cannot find numpy:

2025-03-10T12:49:53.9647326Z     File "<frozen importlib._bootstrap_external>", line 850, in exec_module
2025-03-10T12:49:53.9649758Z     File "<frozen importlib._bootstrap>", line 228, in _call_with_frames_removed
2025-03-10T12:49:53.9657593Z     File "/home/conda/staged-recipes/build_artifacts/hazardous_1741610934033/work/hazardous/__init__.py", line 3, in <module>
2025-03-10T12:49:53.9658079Z       from ._survival_boost import SurvivalBoost
2025-03-10T12:49:53.9663969Z     File "/home/conda/staged-recipes/build_artifacts/hazardous_1741610934033/work/hazardous/_survival_boost.py", line 3, in <module>
2025-03-10T12:49:53.9669194Z       import numpy as np
2025-03-10T12:49:53.9671611Z   ModuleNotFoundError: No module named 'numpy'
2025-03-10T12:49:53.9752585Z   Preparing metadata (pyproject.toml): finished with status 'error'
2025-03-10T12:49:53.9753563Z   error: subprocess-exited-with-error

You may need to add all runtime deps at build time. While that is fine for for this release, it would be nice if you could open an issue upstream to resolve this.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ocefpaf, thank you for the quick response. That's interesting, I've never encountered this issue on skrub, which is another package I maintain on conda-forge. The main difference is that hazardous uses flit while skrub uses setuptools. I will try your suggestion.

While that is fine for for this release, it would be nice if you could open an issue upstream to resolve this.

Do you mean adding an issue on the staged-recipe repo?

Thanks again for your help

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mean adding an issue on the staged-recipe repo?

No. This is an issue with the package, not conda-forge's infrastructure. You will have to add numpy to host here to workaround it.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah ok got it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants