-
-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add r-fivethirtyeightdata #29389
base: main
Are you sure you want to change the base?
Add r-fivethirtyeightdata #29389
Conversation
Hi! This is the staged-recipes linter and your PR looks excellent! 🚀 |
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/r-fivethirtyeightdata/meta.yaml:
This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/13768932826. Examine the logs at this URL for more detail. |
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
@conda-forge/help-r, ready for review. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for submitting this!
Unfortunately, I do not support adding this to Conda Forge for the following reasons:
- the package is not (and cannot be) on CRAN, and as such it lacks regular upstream checks that it maintains consistency with R version releases;
- there has been no active development on this package since its creation (5 years ago), whereas the upstream data source continues to actively release data;
- the audience is unclear and I find no obvious data to indicate the level of demand;
- the license reporting in the R package seems incorrect, specifically the license on the data from the source is CC-BY-4.0 but this package only reports an MIT license, which technically violates CC-BY-4.0.
I would also note that this is a non-compiled package that only delivers data, so using install.packages
as the r-fivethirtyeight
package suggests should work just fine. If a Conda package is entirely necessary, individuals can host Conda packages on personal Anaconda Cloud accounts for free.
All that said, I'm not strongly opposed to this, so if another reviewer from @conda-forge/r wants to let it through, I won't object. However, the license issue should be addressed and the recipe should be changed to noarch
.
Checklist
url
) rather than a repo (e.g.git_url
) is used in your recipe (see here for more details).